Sign upLogin

EscolaLMS/Webinar

View on GitHub
Star
src/routes.php

Summary

Maintainability
A
0 mins
Test Coverage

Call to method group from undeclared class \Illuminate\Support\Facades\Route
Open

Route::group(['prefix' => 'api/webinars'], function () {
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Webinar\Http\Controllers\WebinarController
Open

    Route::resource('webinars', WebinarController::class);
Severity: Critical
Found in src/routes.php by phan

Call to method group from undeclared class \Illuminate\Support\Facades\Route
Open

Route::group(['middleware' => ['auth:api'], 'prefix' => 'api/webinars'], function () {
Severity: Critical
Found in src/routes.php by phan

Call to method get from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::get('/', [WebinarAPIController::class, 'index']);
Severity: Critical
Found in src/routes.php by phan

Call to method get from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::get('/generate-jitsi/{id}', [WebinarAPIController::class, 'generateJitsi']);
Severity: Critical
Found in src/routes.php by phan

Call to method get from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::get('/stop-live-stream/{id}', [WebinarAPIController::class, 'stopLiveStream']);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Webinar\Http\Controllers\WebinarAPIController
Open

    Route::get('/{id}', [WebinarAPIController::class, 'show']);
Severity: Critical
Found in src/routes.php by phan

Call to method resource from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::resource('webinars', WebinarController::class);
Severity: Critical
Found in src/routes.php by phan

Call to method group from undeclared class \Illuminate\Support\Facades\Route
Open

Route::group(['middleware' => ['auth:api'], 'prefix' => 'api/admin'], function () {
Severity: Critical
Found in src/routes.php by phan

Call to method get from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::get('/me', [WebinarAPIController::class, 'forCurrentUser']);
Severity: Critical
Found in src/routes.php by phan

Call to method get from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::get('/{id}', [WebinarAPIController::class, 'show']);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Webinar\Http\Controllers\WebinarAPIController
Open

    Route::get('/generate-jitsi/{id}', [WebinarAPIController::class, 'generateJitsi']);
Severity: Critical
Found in src/routes.php by phan

Call to method post from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::post('webinars/{id}', [WebinarController::class, 'update']);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Webinar\Http\Controllers\WebinarAPIController
Open

    Route::get('/start-live-stream/{id}', [WebinarAPIController::class, 'startLiveStream']);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Webinar\Http\Controllers\WebinarController
Open

    Route::get('webinars/users/assignable', [WebinarController::class, 'assignableUsers']);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Webinar\Http\Controllers\WebinarAPIController
Open

    Route::get('/stop-live-stream/{id}', [WebinarAPIController::class, 'stopLiveStream']);
Severity: Critical
Found in src/routes.php by phan

Call to method get from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::get('webinars/users/assignable', [WebinarController::class, 'assignableUsers']);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Webinar\Http\Controllers\WebinarAPIController
Open

    Route::get('/me', [WebinarAPIController::class, 'forCurrentUser']);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Webinar\Http\Controllers\WebinarController
Open

    Route::post('webinars/{id}', [WebinarController::class, 'update']);
Severity: Critical
Found in src/routes.php by phan

Call to method get from undeclared class \Illuminate\Support\Facades\Route
Open

    Route::get('/start-live-stream/{id}', [WebinarAPIController::class, 'startLiveStream']);
Severity: Critical
Found in src/routes.php by phan

Reference to constant class from undeclared class \EscolaLms\Webinar\Http\Controllers\WebinarAPIController
Open

    Route::get('/', [WebinarAPIController::class, 'index']);
Severity: Critical
Found in src/routes.php by phan

Define a constant instead of duplicating this literal "prefix" 3 times.
Open

Route::group(['middleware' => ['auth:api'], 'prefix' => 'api/admin'], function () {
Severity: Critical
Found in src/routes.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

There are no issues that match your filters.

Category
Status