Sign upLogin

EscolaLMS/model-fields

View on GitHub
Star

Showing 192 of 192 total issues

Possibly zero references to use statement for classlike/namespace FacadesTemplate (\EscolaLms\Templates\Facades\Template)
Open

use EscolaLms\Templates\Facades\Template as FacadesTemplate;
Severity: Minor
Found in src/Http/Requests/MetadataCreateOrUpdateRequest.php by phan

Class extends undeclared class \Illuminate\Database\Eloquent\Model
Open

class Metadata extends Model
Severity: Critical
Found in src/Models/Metadata.php by phan

Call to method can from undeclared class \EscolaLms\Core\Models\User
Open

        return !is_null($user) && $user->can(MetaFieldPermissionsEnum::METADATA_CREATE_UPDATE);
Severity: Critical
Found in src/Policies/MetadataPolicy.php by phan

syntax error, unexpected 'Collection' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
Open

    private Collection $extraFields;
Severity: Critical
Found in src/Traits/ModelFields.php by phan

Class extends undeclared class \Illuminate\Foundation\Http\FormRequest
Open

class MetadataListRequest extends FormRequest
Severity: Critical
Found in src/Http/Requests/MetadataListRequest.php by phan

Reference to constant class from undeclared class \EscolaLms\ModelFields\Http\Controllers\ModelFieldsAdminApiController
Open

    Route::post('/', [ModelFieldsAdminApiController::class, 'createOrUpdate']);
Severity: Critical
Found in src/routes.php by phan

Remove the unused function parameter "$template".
Open

    public function delete(?User $user, Metadata $template = null): bool
Severity: Major
Found in src/Policies/MetadataPolicy.php by sonar-php

Unused parameters are misleading. Whatever the value passed to such parameters is, the behavior will be the same.

Noncompliant Code Example

function doSomething($a, $b) { // "$a" is unused
  return compute($b);
}

Compliant Solution

function doSomething($b) {
  return compute($b);
}

Exceptions

Functions in classes that override a class or implement interfaces are ignored.

class C extends B {

  function doSomething($a, $b) {     // no issue reported on $b
    compute($a);
  }

}

See

  • MISRA C++:2008, 0-1-11 - There shall be no unused parameters (named or unnamed) in nonvirtual functions.
  • MISRA C:2012, 2.7 - There should be no unused parameters in functions
  • CERT, MSC12-C. - Detect and remove code that has no effect or is never executed
  • CERT, MSC12-CPP. - Detect and remove code that has no effect

Remove the unused function parameter "$user".
Open

    public function list(?User $user): bool
Severity: Major
Found in src/Policies/MetadataPolicy.php by sonar-php

Unused parameters are misleading. Whatever the value passed to such parameters is, the behavior will be the same.

Noncompliant Code Example

function doSomething($a, $b) { // "$a" is unused
  return compute($b);
}

Compliant Solution

function doSomething($b) {
  return compute($b);
}

Exceptions

Functions in classes that override a class or implement interfaces are ignored.

class C extends B {

  function doSomething($a, $b) {     // no issue reported on $b
    compute($a);
  }

}

See

  • MISRA C++:2008, 0-1-11 - There shall be no unused parameters (named or unnamed) in nonvirtual functions.
  • MISRA C:2012, 2.7 - There should be no unused parameters in functions
  • CERT, MSC12-C. - Detect and remove code that has no effect or is never executed
  • CERT, MSC12-CPP. - Detect and remove code that has no effect

Define a constant instead of duplicating this literal "string" 4 times.
Open

        'name' => 'string',
Severity: Critical
Found in src/Models/Metadata.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "string" 3 times.
Open

            'name' => ['required', 'string'],
Severity: Critical
Found in src/Http/Requests/MetadataCreateOrUpdateRequest.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "required" 3 times.
Open

            'name' => ['required', 'string'],
Severity: Critical
Found in src/Http/Requests/MetadataCreateOrUpdateRequest.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "string" 3 times.
Open

        'name' => 'string',
Severity: Critical
Found in src/Models/Field.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Severity
Category
Status
Source
Language