Sign upLogin

EscolaLMS/model-fields

View on GitHub
Star
src/Http/Controllers/ModelFieldsAdminApiController.php

Summary

Maintainability
A
0 mins
Test Coverage
A
96%

Avoid using static access to class '\EscolaLms\Core\Dtos\OrderDto' in method 'list'.
Open

        $metaFields = $this->service->getFieldsMetadataListPaginated($classType, $perPage, OrderDto::instantiateFromRequest($request));
Severity: Minor
Found in src/Http/Controllers/ModelFieldsAdminApiController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EscolaLms\ModelFields\Http\Resources\MetadataResource' in method 'createOrUpdate'.
Open

        return $this->sendResponseForResource(MetadataResource::make($field), "meta field created or updated successfully");
Severity: Minor
Found in src/Http/Controllers/ModelFieldsAdminApiController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EscolaLms\ModelFields\Http\Resources\MetadataResource' in method 'list'.
Open

        return $this->sendResponseForResource(MetadataResource::collection($metaFields), "metaFields list retrieved successfully");
Severity: Minor
Found in src/Http/Controllers/ModelFieldsAdminApiController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

syntax error, unexpected 'ModelFieldsServiceContract' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
Open

    private ModelFieldsServiceContract $service;
Severity: Critical
Found in src/Http/Controllers/ModelFieldsAdminApiController.php by phan

Line exceeds 120 characters; contains 135 characters
Open

        return $bool ? $this->sendResponse(true, "meta field deleted successfully") : $this->sendError("meta field delete error", 404);
Severity: Minor
Found in src/Http/Controllers/ModelFieldsAdminApiController.php by phpcodesniffer

Line exceeds 120 characters; contains 124 characters
Open

        return $this->sendResponseForResource(MetadataResource::make($field), "meta field created or updated successfully");
Severity: Minor
Found in src/Http/Controllers/ModelFieldsAdminApiController.php by phpcodesniffer

Line exceeds 120 characters; contains 135 characters
Open

        $metaFields = $this->service->getFieldsMetadataListPaginated($classType, $perPage, OrderDto::instantiateFromRequest($request));
Severity: Minor
Found in src/Http/Controllers/ModelFieldsAdminApiController.php by phpcodesniffer

Line exceeds 120 characters; contains 131 characters
Open

        return $this->sendResponseForResource(MetadataResource::collection($metaFields), "metaFields list retrieved successfully");
Severity: Minor
Found in src/Http/Controllers/ModelFieldsAdminApiController.php by phpcodesniffer

There are no issues that match your filters.

Category
Status