EscolaLMS/model-fields

View on GitHub
src/Http/Controllers/ModelFieldsApiController.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Avoid using static access to class '\EscolaLms\ModelFields\Http\Resources\MetadataResource' in method 'list'.
Open

        return $this->sendResponseForResource(MetadataResource::collection($metaFields), "metaFields list retrieved successfully");

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

syntax error, unexpected 'ModelFieldsServiceContract' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
Open

    private ModelFieldsServiceContract $service;

Line exceeds 120 characters; contains 131 characters
Open

        return $this->sendResponseForResource(MetadataResource::collection($metaFields), "metaFields list retrieved successfully");

There are no issues that match your filters.

Category
Status