Sign upLogin

EventGhost/EventGhost

View on GitHub
Star
eg/Classes/LanguageEditor.py

Summary

Maintainability
F
4 days
Test Coverage

File LanguageEditor.py has 475 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
#
# This file is part of EventGhost.
# Copyright © 2005-2020 EventGhost Project <http://www.eventghost.net/>
#
Severity: Minor
Found in eg/Classes/LanguageEditor.py - About 7 hrs to fix

    Function OnCmdSave has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
    Open

        def OnCmdSave(self, dummyEvent=None):
        self.StoreEditField()
        tree = self.tree
        indentString = "    "
    Severity: Minor
    Found in eg/Classes/LanguageEditor.py - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function OnCmdFindNext has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

        def OnCmdFindNext(self, dummyEvent=None, currentId=None):
        tree = self.tree
        if currentId is None:
            currentId = tree.GetSelection()
        treeId = currentId
    Severity: Minor
    Found in eg/Classes/LanguageEditor.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    LanguageEditor has 23 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class LanguageEditor(wx.Frame):
    def __init__(self, parent=None):
        self.translationDict = None

        if Config.language is None:
    Severity: Minor
    Found in eg/Classes/LanguageEditor.py - About 2 hrs to fix

      Function FillTree has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          def FillTree(self, treeId, node, evalPath=""):
        tree = self.tree
        for key, value in self.SortItems(node):
            if evalPath == "":
                newEvalPath = key
      Severity: Minor
      Found in eg/Classes/LanguageEditor.py - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function SortItems has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          def SortItems(node):
        firstItems = []
        valueItems = []
        groupItems = []
        for key in dir(node):
      Severity: Minor
      Found in eg/Classes/LanguageEditor.py - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __init__ has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def __init__(self, parent=None):
        self.translationDict = None

        if Config.language is None:
            Config.language = eg.config.language
      Severity: Minor
      Found in eg/Classes/LanguageEditor.py - About 1 hr to fix

        Function __init__ has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            def __init__(self, parent=None):
        self.translationDict = None

        if Config.language is None:
            Config.language = eg.config.language
        Severity: Minor
        Found in eg/Classes/LanguageEditor.py - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                                if not treeId.IsOk():
                            print "unknown"
                            found = True
                            treeId = self.rootId
                            break
        Severity: Major
        Found in eg/Classes/LanguageEditor.py - About 45 mins to fix

          Function LoadLanguage has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def LoadLanguage(self, language):
        Config.language = language
        self.isDirty = False
        self.SetTitle(
            "EventGhost Language Editor - %s [%s]" %
          Severity: Minor
          Found in eg/Classes/LanguageEditor.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                                  if newId.IsOk():
                            treeId = newId
                            break
            while tree.ItemHasChildren(treeId):
          Severity: Major
          Found in eg/Classes/LanguageEditor.py - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            elif isinstance(value, tuple):
                    tmp = Traverse(item, indent + 1, True)
                    if tmp != "":
                        append(indentString * indent + key + " = (\n")
                        append(tmp)
            Severity: Major
            Found in eg/Classes/LanguageEditor.py and 1 other location - About 2 hrs to fix
            eg/Classes/LanguageEditor.py on lines 396..401

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 79.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            elif isinstance(value, list):
                    tmp = Traverse(item, indent + 1, True)
                    if tmp != "":
                        append(indentString * indent + key + " = [\n")
                        append(tmp)
            Severity: Major
            Found in eg/Classes/LanguageEditor.py and 1 other location - About 2 hrs to fix
            eg/Classes/LanguageEditor.py on lines 402..407

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 79.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status