Sign upLogin

EventGhost/EventGhost

View on GitHub
Star
plugins/Atric_IRWakeupUSB/__init__.py

Summary

Maintainability
F
1 wk
Test Coverage

File __init__.py has 1182 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
#
# This file is a plugin for EventGhost.
# Copyright © EventGhost Project <http://www.eventghost.net/>
#
Severity: Major
Found in plugins/Atric_IRWakeupUSB/__init__.py - About 3 days to fix

    Function __call__ has a Cognitive Complexity of 83 (exceeds 5 allowed). Consider refactoring.
    Open

        def __call__(
        self,
        num_bytes=None,
        timeout=1,
        returnformat="Hex",
    Severity: Minor
    Found in plugins/Atric_IRWakeupUSB/__init__.py - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Cyclomatic complexity is too high in method __call__. (39)
    Open

    
    def __call__(
        self,
        num_bytes=None,
        timeout=1,
    Severity: Minor
    Found in plugins/Atric_IRWakeupUSB/__init__.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function Configure has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def Configure(
        self,
        data="",
        timeout=0.2,
        read_num_bytes=None,
    Severity: Minor
    Found in plugins/Atric_IRWakeupUSB/__init__.py - About 1 hr to fix

      Function Configure has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def Configure(
        self,
        waketime="0000000000",
        year=0,
        month=1,
      Severity: Minor
      Found in plugins/Atric_IRWakeupUSB/__init__.py - About 1 hr to fix

        Function __call__ has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            def __call__(
        self,
        data="",
        timeout=0.2,
        read_num_bytes=None,
        Severity: Minor
        Found in plugins/Atric_IRWakeupUSB/__init__.py - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function Configure has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def Configure(
        self,
        num_bytes=None,
        timeout=1,
        returnformat="Hex",
        Severity: Minor
        Found in plugins/Atric_IRWakeupUSB/__init__.py - About 1 hr to fix

          Function Configure has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def Configure(
          Severity: Major
          Found in plugins/Atric_IRWakeupUSB/__init__.py - About 1 hr to fix

            Function __start__ has 9 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def __start__(
            Severity: Major
            Found in plugins/Atric_IRWakeupUSB/__init__.py - About 1 hr to fix

              Function __start__ has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  def __start__(
        self,
        port=0,
        baudrate=9600,
        bytesize=3,
              Severity: Minor
              Found in plugins/Atric_IRWakeupUSB/__init__.py - About 1 hr to fix

                Function Configure has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    def Configure(
        self,
        waketime="0000000000",
        year=0,
        month=1,
                Severity: Minor
                Found in plugins/Atric_IRWakeupUSB/__init__.py - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function __start__ has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    def __start__(
        self,
        port=0,
        baudrate=9600,
        bytesize=3,
                Severity: Minor
                Found in plugins/Atric_IRWakeupUSB/__init__.py - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function Configure has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def Configure(
                Severity: Major
                Found in plugins/Atric_IRWakeupUSB/__init__.py - About 50 mins to fix

                  Function __call__ has 7 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def __call__(
                  Severity: Major
                  Found in plugins/Atric_IRWakeupUSB/__init__.py - About 50 mins to fix

                    Function __call__ has 7 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def __call__(
                    Severity: Major
                    Found in plugins/Atric_IRWakeupUSB/__init__.py - About 50 mins to fix

                      Function Configure has 7 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          def Configure(
                      Severity: Major
                      Found in plugins/Atric_IRWakeupUSB/__init__.py - About 50 mins to fix

                        Function Configure has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                            def Configure(
        self,
        data="",
        timeout=0.2,
        read_num_bytes=None,
                        Severity: Minor
                        Found in plugins/Atric_IRWakeupUSB/__init__.py - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function Configure has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            def Configure(
        self,
        num_bytes=None,
        timeout=1,
        returnformat="Hex",
                        Severity: Minor
                        Found in plugins/Atric_IRWakeupUSB/__init__.py - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            def Configure(self, daylight=1):
        text = self.text
        panel = eg.ConfigPanel()

        daylight_ctrl = panel.CheckBox(daylight, text.daylight_ctrl_label)
                        Severity: Major
                        Found in plugins/Atric_IRWakeupUSB/__init__.py and 1 other location - About 3 hrs to fix
                        plugins/Atric_IRWakeupUSB/__init__.py on lines 1456..1471

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 97.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            def Configure(self, infrared=1):
        text = self.text
        panel = eg.ConfigPanel()

        infrared_ctrl = panel.CheckBox(infrared, text.infrared_ctrl_label)
                        Severity: Major
                        Found in plugins/Atric_IRWakeupUSB/__init__.py and 1 other location - About 3 hrs to fix
                        plugins/Atric_IRWakeupUSB/__init__.py on lines 1235..1250

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 97.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        class get_firmware_version(eg.ActionBase):
    def __call__(self):
        temp = write_advanced()

        returndata = temp(
                        Severity: Major
                        Found in plugins/Atric_IRWakeupUSB/__init__.py and 1 other location - About 1 hr to fix
                        plugins/Atric_IRWakeupUSB/__init__.py on lines 1499..1512

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 72.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        class get_hardware_version(eg.ActionBase):
    def __call__(self):
        temp = write_advanced()

        returndata = temp(
                        Severity: Major
                        Found in plugins/Atric_IRWakeupUSB/__init__.py and 1 other location - About 1 hr to fix
                        plugins/Atric_IRWakeupUSB/__init__.py on lines 1483..1496

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 72.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                while panel.Affirmed():
            panel.SetResult(
                port_ctrl.GetValue(),
                int(baudrate_ctrl.GetValue()),
                bytesize_ctrl.GetValue(),
                        Severity: Minor
                        Found in plugins/Atric_IRWakeupUSB/__init__.py and 1 other location - About 55 mins to fix
                        plugins/HarmanKardon/__init__.py on lines 357..367

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 65.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status