Sign upLogin

EventGhost/EventGhost

View on GitHub
Star
plugins/Barco/__init__.py

Summary

Maintainability
F
5 days
Test Coverage

File __init__.py has 450 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
#
# This file is a plugin for EventGhost.
# Copyright © 2005-2020 EventGhost Project <http://www.eventghost.net/>
#
Severity: Minor
Found in plugins/Barco/__init__.py - About 6 hrs to fix

    Function SendCommand has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def SendCommand(
    Severity: Major
    Found in plugins/Barco/__init__.py - About 50 mins to fix

      Function __call__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __call__(self, kind, x=0, y=0, value=128, flags=3):
      Severity: Minor
      Found in plugins/Barco/__init__.py - About 35 mins to fix

        Function Configure has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def Configure(self, kind=0, x=0, y=0, value=128, flags=3):
        Severity: Minor
        Found in plugins/Barco/__init__.py - About 35 mins to fix

          Function __call__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def __call__(self, cmd, dat1, dat2, dat3, dat4):
          Severity: Minor
          Found in plugins/Barco/__init__.py - About 35 mins to fix

            Function Configure has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def Configure(self, cmd=0, dat1=0, dat2=0, dat3=0, dat4=0):
            Severity: Minor
            Found in plugins/Barco/__init__.py - About 35 mins to fix

              Function SendCommand has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def SendCommand(
        self, serial, cmd, dat1=0, dat2=0, dat3=0, dat4=0, block=None
    ):
        data = [self.plugin.address, cmd, dat1, dat2, dat3, dat4]
        checksum = sum(data) % 256
              Severity: Minor
              Found in plugins/Barco/__init__.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          if extraInfo:
                print "Magnetic focus:", bool(dat3 & (1 << 6))
                print "Convergence is stripped:", bool(dat3 & (1 << 7))
                print "Orbiting installed:", bool(dat4 & (1 << 0))
                print "Soft edge installed:", bool(dat4 & (1 << 1))
              Severity: Major
              Found in plugins/Barco/__init__.py and 1 other location - About 1 day to fix
              plugins/Barco/__init__.py on lines 229..240

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 184.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          if extraInfo:
                print "Magnetic focus:", bool(dat3 & (1 << 6))
                print "Convergence is stripped:", bool(dat3 & (1 << 7))
                print "Orbiting installed:", bool(dat4 & (1 << 0))
                print "Soft edge installed:", bool(dat4 & (1 << 1))
              Severity: Major
              Found in plugins/Barco/__init__.py and 1 other location - About 1 day to fix
              plugins/Barco/__init__.py on lines 295..306

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 184.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          digits = (
                chr(48 + (dat1 & 0x0f)),
                chr(48 + (dat2 / 16)),
                chr(48 + (dat2 & 0x0f)),
                chr(48 + (dat3 / 16)),
              Severity: Major
              Found in plugins/Barco/__init__.py and 1 other location - About 5 hrs to fix
              plugins/Barco/__init__.py on lines 309..316

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 125.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          digits = (
                chr(48 + (dat1 & 0x0f)),
                chr(48 + (dat2 / 16)),
                chr(48 + (dat2 & 0x0f)),
                chr(48 + (dat3 / 16)),
              Severity: Major
              Found in plugins/Barco/__init__.py and 1 other location - About 5 hrs to fix
              plugins/Barco/__init__.py on lines 266..273

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 125.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status