Sign upLogin

EventGhost/EventGhost

View on GitHub
Star
plugins/CM11A/__init__.py

Summary

Maintainability
C
1 day
Test Coverage

Function OnReceive has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

    def OnReceive(self, serial):
        ###print "OnReceive"
        buffer = ""
        while True:
            b = serial.Read(1, 0.1)
Severity: Minor
Found in plugins/CM11A/__init__.py - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File __init__.py has 318 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
#
# plugins/CM11A /__init__.py
#
# Written by Silviu Marghescu
Severity: Minor
Found in plugins/CM11A/__init__.py - About 3 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                            if lastAddr:
                            self.GenerateEvent(lastAddr + "." + functionCode)
                            lastAddr = None
                        else:
                            self.GenerateEvent(houseCode + "." + functionCode)
    Severity: Major
    Found in plugins/CM11A/__init__.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if functionCode in ("Dim", "Bright"):
                            dimByte = ord(buffer[i+3])
                            i = i + 1
                            dimVal = round(dimByte*100/210)
                            functionCode = functionCode + "." + str(dimVal)
      Severity: Major
      Found in plugins/CM11A/__init__.py - About 45 mins to fix

        Avoid too many return statements within this function.
        Open

                            return
        Severity: Major
        Found in plugins/CM11A/__init__.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                              return
          Severity: Major
          Found in plugins/CM11A/__init__.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return
            Severity: Major
            Found in plugins/CM11A/__init__.py - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status