EventGhost/EventGhost

View on GitHub
plugins/DesktopRemote/__init__.py

Summary

Maintainability
D
2 days
Test Coverage

File __init__.py has 482 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
#
# This file is a plugin for EventGhost.
# Copyright © 2005-2020 EventGhost Project <http://www.eventghost.net/>
#
Severity: Minor
Found in plugins/DesktopRemote/__init__.py - About 7 hrs to fix

    Function CreateRemote has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

    def CreateRemote(plugin, xPos, yPos, alwaysOnTop):
        data = plugin.data
        borderSize = plugin.borderSize
    
        if plugin.frame:
    Severity: Minor
    Found in plugins/DesktopRemote/__init__.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __call__ has 15 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __call__(
    Severity: Major
    Found in plugins/DesktopRemote/__init__.py - About 1 hr to fix

      Function Configure has 15 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def Configure(
      Severity: Major
      Found in plugins/DesktopRemote/__init__.py - About 1 hr to fix

        Function Configure has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def Configure(
                self,
                width=40,
                height=40,
                rowGap=3,
        Severity: Minor
        Found in plugins/DesktopRemote/__init__.py - About 1 hr to fix

          Function Configure has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              def Configure(self, kwargs={}):
          
                  def MakeOption(name, checkBox, ctrl):
                      value = kwargs.get(name, None)
                      def OnCheckBox(event):
          Severity: Minor
          Found in plugins/DesktopRemote/__init__.py - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function SetValue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def SetValue(self, value):
                  self.value = value
                  if value and self.view:
                      stream = StringIO(b64decode(value))
                      image = wx.ImageFromStream(stream)
          Severity: Minor
          Found in plugins/DesktopRemote/__init__.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if dialog.ShowModal() == wx.ID_OK:
                      filePath = dialog.GetPath()
                      imageFile = open(filePath, "rb")
                      stream = imageFile.read()
                      imageFile.close()
          Severity: Major
          Found in plugins/DesktopRemote/__init__.py and 1 other location - About 1 hr to fix
          eg/Classes/ImagePicker.py on lines 56..62

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status