Function handle_read has a Cognitive Complexity of 112 (exceeds 5 allowed). Consider refactoring. Open
def handle_read(self):
# Append data from the socket onto a buffer
self.buffer += self.recv(4096)
# Attempt to detect delimeter used..
if self.delimeter == '':- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File __init__.py has 557 lines of code (exceeds 250 allowed). Consider refactoring. Open
### Script for handling (Win)Lirc events by jinxdone - 16th December 2007
###
###
### EventGhost plugin for receiving Lirc-style events written in python.
###Function Configure has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring. Open
def Configure(self, actionStr=""):
text = self.text
actionParam = "0"
if len(self.remotes) == 0:
self.remotes.append(["N/A", ['N/A']])- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Cyclomatic complexity is too high in method handle_read. (31) Open
def handle_read(self):
# Append data from the socket onto a buffer
self.buffer += self.recv(4096)
# Attempt to detect delimeter used..
if self.delimeter == '':- Read upRead up
- Exclude checks
Cyclomatic Complexity
Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.
Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:
| Construct | Effect on CC | Reasoning |
|---|---|---|
| if | +1 | An if statement is a single decision. |
| elif | +1 | The elif statement adds another decision. |
| else | +0 | The else statement does not cause a new decision. The decision is at the if. |
| for | +1 | There is a decision at the start of the loop. |
| while | +1 | There is a decision at the while statement. |
| except | +1 | Each except branch adds a new conditional path of execution. |
| finally | +0 | The finally block is unconditionally executed. |
| with | +1 | The with statement roughly corresponds to a try/except block (see PEP 343 for details). |
| assert | +1 | The assert statement internally roughly equals a conditional statement. |
| Comprehension | +1 | A list/set/dict comprehension of generator expression is equivalent to a for loop. |
| Boolean Operator | +1 | Every boolean operator (and, or) adds a decision point. |
Function Configure has 57 lines of code (exceeds 25 allowed). Consider refactoring. Open
def Configure(
self,
host="127.0.0.1",
port=8765,
onlyfirst = False,Function Configure has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
def Configure(self, actionStr=""):
text = self.text
actionParam = "0"
if len(self.remotes) == 0:
self.remotes.append(["N/A", ['N/A']])Function Configure has 11 arguments (exceeds 4 allowed). Consider refactoring. Open
def Configure(Function __start__ has 11 arguments (exceeds 4 allowed). Consider refactoring. Open
def __start__(Function __init__ has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
def __init__(Avoid deeply nested control flow statements. Open
for remote in self.handler.Send.remotelist:
self.sbuffer += "LIST " + remote + "\n"
Avoid deeply nested control flow statements. Open
if self.remote != "":
# Sanity check.. if there is not enough data skip it..
if len(self.events) > int(self.events[i + 4]) + 4:
self.checknum = 0Avoid deeply nested control flow statements. Open
if 0 < repeat <= 600:
repeatCtrl.SetValue(repeat)
Avoid too many return statements within this function. Open
return True