Sign upLogin

EventGhost/EventGhost

View on GitHub
Star
plugins/RFXcom_xPL/__init__.py

Summary

Maintainability
F
4 days
Test Coverage

File __init__.py has 554 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#
# This file is a plugin for EventGhost.
# plugins/RFXcom_xPL/__init__.py
#
# Copyright (C) 2009
Severity: Major
Found in plugins/RFXcom_xPL/__init__.py - About 1 day to fix

    Function main has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
    Open

        def main(self,mainThreadEvent):
        messageOld = ""
        while not mainThreadEvent.isSet():
            readable, writeable, errored = select.select([self.UDPSock],[],[],60)
            if len(readable) == 1 :
    Severity: Minor
    Found in plugins/RFXcom_xPL/__init__.py - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function Configure has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def Configure(
        self,
        name="Give me a name",
        schema="",
        protocol="",
    Severity: Major
    Found in plugins/RFXcom_xPL/__init__.py - About 2 hrs to fix

      Function Configure has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def Configure(
        self,
        name="Give me a name",
        schema="",
        address="0x...",
      Severity: Major
      Found in plugins/RFXcom_xPL/__init__.py - About 2 hrs to fix

        Function Configure has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            def Configure(
        self,
        name="Give me a name",
        schema="",
        protocol="",
        Severity: Minor
        Found in plugins/RFXcom_xPL/__init__.py - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function Configure has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            def Configure(
        self,
        name="Give me a name",
        schema="",
        address="0x...",
        Severity: Minor
        Found in plugins/RFXcom_xPL/__init__.py - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function Configure has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def Configure(
        Severity: Minor
        Found in plugins/RFXcom_xPL/__init__.py - About 45 mins to fix

          Function __call__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def __call__(self, name, schema, address, unit, command, level):
          Severity: Minor
          Found in plugins/RFXcom_xPL/__init__.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if message <> messageOld:
                            for element in msgbody:
                                msgbody2 = msgbody2 + element + ","
                            self.TriggerEvent(
                                xpltype
            Severity: Major
            Found in plugins/RFXcom_xPL/__init__.py - About 45 mins to fix

              Function __call__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def __call__(self, name, schema, protocol, house, pdevice, command):
              Severity: Minor
              Found in plugins/RFXcom_xPL/__init__.py - About 45 mins to fix

                Function Configure has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def Configure(
                Severity: Minor
                Found in plugins/RFXcom_xPL/__init__.py - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                          if self.xplsourceHB > 10:
                            self.xplsourceHB = 10
                  Severity: Major
                  Found in plugins/RFXcom_xPL/__init__.py - About 45 mins to fix

                    Function Configure has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def Configure(
                    Severity: Minor
                    Found in plugins/RFXcom_xPL/__init__.py - About 35 mins to fix

                      Function LogToFile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def LogToFile(self, s):
        timeStamp = str(
            time.strftime("%Y-%m-%d %H:%M:%S", time.localtime())
        )
        logStr = timeStamp+"\t"+s+"<br\n>"
                      Severity: Minor
                      Found in plugins/RFXcom_xPL/__init__.py - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                          def SendHeartbeat(self, hbThreadEvent) :
        hbSock = socket(AF_INET, SOCK_DGRAM)
        hbSock.setsockopt(SOL_SOCKET, SO_BROADCAST, 1)
        while not hbThreadEvent.isSet():
            msg = (
                      Severity: Major
                      Found in plugins/RFXcom_xPL/__init__.py and 1 other location - About 6 hrs to fix
                      plugins/xPL/__init__.py on lines 91..98

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 132.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                              msg = (
            "xpl-cmnd"
            +"\n{\nhop=1\nsource="
            +self.plugin.hostname
            +"\ntarget="
                      Severity: Major
                      Found in plugins/RFXcom_xPL/__init__.py and 1 other location - About 1 hr to fix
                      plugins/RFXcom_xPL/__init__.py on lines 557..567

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 67.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                              msg = (
            "xpl-cmnd"
            +"\n{\nhop=1\nsource="
            +self.plugin.hostname
            +"\ntarget="
                      Severity: Major
                      Found in plugins/RFXcom_xPL/__init__.py and 1 other location - About 1 hr to fix
                      plugins/RFXcom_xPL/__init__.py on lines 357..367

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 67.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status