EventGhost/EventGhost

View on GitHub
plugins/SoundMixerEx/__init__.py

Summary

Maintainability
D
2 days
Test Coverage

File __init__.py has 447 lines of code (exceeds 250 allowed). Consider refactoring.
Open

eg.RegisterPlugin(
    name = "Sound Mixer Ex",
    author = "Dexter",
    version = "1.1.1204",
    description = (
Severity: Minor
Found in plugins/SoundMixerEx/__init__.py - About 6 hrs to fix

    Function GetTree has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        def GetTree(self, panel, classVisible, mixerSelect, controlSelect):
            mixerLast = ""
            mixerItem = None
            dstLast = ""
            dstItem = None
    Severity: Minor
    Found in plugins/SoundMixerEx/__init__.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function GetDeviceLines has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def GetDeviceLines(self, deviceId=0):
            mixercaps = MIXERCAPS()
            mixerline = MIXERLINE()
            result = []
    
    
    Severity: Minor
    Found in plugins/SoundMixerEx/__init__.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function GetControls has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def GetControls(self, hmixer, mixerline):
            numCtrls = mixerline.cControls
            if numCtrls == 0:
                return []
    
    
    Severity: Minor
    Found in plugins/SoundMixerEx/__init__.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function Configure has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def Configure(self, deviceId=-1, controlId=-1, name="", value=0, relative=1):
    Severity: Minor
    Found in plugins/SoundMixerEx/__init__.py - About 35 mins to fix

      Function __call__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __call__(self, deviceId=-1, controlId=-1, name="", value=0, relative=1):
      Severity: Minor
      Found in plugins/SoundMixerEx/__init__.py - About 35 mins to fix

        Function GetLabel has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def GetLabel(self, deviceId=-1, controlId=-1, name="", value=0, relative=1):
        Severity: Minor
        Found in plugins/SoundMixerEx/__init__.py - About 35 mins to fix

          Function __call__ has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def __call__(self, deviceId=-1, controlId=-1, name="", value=0):
                  if deviceId == -1 or controlId == -1:
                      self.printError("No device/control selected")
                  else:
                      if value == 0:
          Severity: Minor
          Found in plugins/SoundMixerEx/__init__.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function GetLabel has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def GetLabel(self, deviceId=-1, controlId=-1, name="", value=0, relative=1):
                  if deviceId == -1 or controlId == -1:
                      return "No device/control selected"
                  if relative == 1:
                      if value > 0:
          Severity: Minor
          Found in plugins/SoundMixerEx/__init__.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function GetControls has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def GetControls(self):
                  if self.controls is None:
                      self.controls = []
                      mixers = self.GetMixers()
                      for mixerId, mixerName in mixers:
          Severity: Minor
          Found in plugins/SoundMixerEx/__init__.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          MIXER_CONTROL_CLASSES = {
              MIXERCONTROL_CT_CLASS_FADER: {
                  "name": "Fader",
                  "types": {
                      MIXERCONTROL_CONTROLTYPE_VOLUME: "Volume",
          Severity: Major
          Found in plugins/SoundMixerEx/__init__.py and 1 other location - About 7 hrs to fix
          eg/WinApi/SoundMixer.py on lines 89..156

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 143.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status