Sign upLogin

EventGhost/EventGhost

View on GitHub
Star
plugins/System/Registry.py

Summary

Maintainability
F
6 days
Test Coverage

File Registry.py has 714 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
#
# This file is part of EventGhost.
# Copyright © 2005-2020 EventGhost Project <http://www.eventghost.net/>
#
Severity: Major
Found in plugins/System/Registry.py - About 1 day to fix

    Function OnTreeChange has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
    Open

        def OnTreeChange(
        self,
        event,
        key2Select = None,
        subkey2Select = None,
    Severity: Minor
    Found in plugins/System/Registry.py - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __call__ has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
    Open

        def __call__(
        self,
        key,
        subkey,
        valueName,
    Severity: Minor
    Found in plugins/System/Registry.py - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __call__ has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        def __call__(self, key, subkey, valueName, action, compareValue):
        if not key:  #nothing selected
            return None

        success = False
    Severity: Minor
    Found in plugins/System/Registry.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Cyclomatic complexity is too high in method __call__. (22)
    Open

    
    def __call__(
        self,
        key,
        subkey,
    Severity: Minor
    Found in plugins/System/Registry.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function FillOldValue has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def FillOldValue(self, key, subkey, valueName):
        curType = None
        curValue = None
        if valueName is not None:
            try:
    Severity: Minor
    Found in plugins/System/Registry.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def __init__(
        self,
        parent,
        id = -1,
        text = None,
    Severity: Minor
    Found in plugins/System/Registry.py - About 1 hr to fix

      Function Configure has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def Configure(
        self,
        key = None,
        subkey = None,
        valueName = None,
      Severity: Minor
      Found in plugins/System/Registry.py - About 1 hr to fix

        Function __init__ has 11 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(
        Severity: Major
        Found in plugins/System/Registry.py - About 1 hr to fix

          Function Configure has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def Configure(
        self,
        key = None,
        subkey = None,
        valueName = None,
          Severity: Minor
          Found in plugins/System/Registry.py - About 1 hr to fix

            Function Configure has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                def Configure(
        self,
        key = None,
        subkey = None,
        valueName = None,
            Severity: Minor
            Found in plugins/System/Registry.py - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function FullKeyName has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

            def FullKeyName(key, subkey, valueName, maxSubkeyLength=15):
    label = "root"
    if not key:
        return label
            Severity: Minor
            Found in plugins/System/Registry.py - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function __init__ has 9 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def __init__(
            Severity: Major
            Found in plugins/System/Registry.py - About 1 hr to fix

              Function OnTreeSelect has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  def OnTreeSelect(self, event):
        key, subkey, valueName = self.tree.GetValue()
        if key is not None:  #change only if not root node
            if valueName is None:
                self.valueNameCtrl.SetValue("")
              Severity: Minor
              Found in plugins/System/Registry.py - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function Configure has 8 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def Configure(
              Severity: Major
              Found in plugins/System/Registry.py - About 1 hr to fix

                Function __call__ has 8 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def __call__(
                Severity: Major
                Found in plugins/System/Registry.py - About 1 hr to fix

                  Function GetLabel has 8 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def GetLabel(
                  Severity: Major
                  Found in plugins/System/Registry.py - About 1 hr to fix

                    Function GetLabel has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def GetLabel(self, key, subkey, valueName, action, compareValue):
                    Severity: Minor
                    Found in plugins/System/Registry.py - About 45 mins to fix

                      Function Configure has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def Configure(
        self,
        key = None,
        subkey = None,
        valueName = None,
                      Severity: Minor
                      Found in plugins/System/Registry.py - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function Configure has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          def Configure(
                      Severity: Minor
                      Found in plugins/System/Registry.py - About 45 mins to fix

                        Function __call__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            def __call__(self, key, subkey, valueName, action, compareValue):
                        Severity: Minor
                        Found in plugins/System/Registry.py - About 45 mins to fix

                          Function OnSubkeyEnter has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def OnSubkeyEnter(self, event):
        value = self.subkeyCtrl.GetValue()
        if value.startswith("HK") and value.count("\\") > 0:
            #probably a whole key pasted
            tmp = value.split("\\", 1)
                          Severity: Minor
                          Found in plugins/System/Registry.py - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function OnTreeChange has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              def OnTreeChange(
                          Severity: Minor
                          Found in plugins/System/Registry.py - About 35 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                    return label + "\\" + valueName
                            Severity: Major
                            Found in plugins/System/Registry.py - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                              return False
                              Severity: Major
                              Found in plugins/System/Registry.py - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                                return True
                                Severity: Major
                                Found in plugins/System/Registry.py - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                                  return 1
                                  Severity: Major
                                  Found in plugins/System/Registry.py - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                                    return 0
                                    Severity: Major
                                    Found in plugins/System/Registry.py - About 30 mins to fix

                                      Avoid too many return statements within this function.
                                      Open

                                                      return False
                                      Severity: Major
                                      Found in plugins/System/Registry.py - About 30 mins to fix

                                        Avoid too many return statements within this function.
                                        Open

                                                    return 0
                                        Severity: Major
                                        Found in plugins/System/Registry.py - About 30 mins to fix

                                          Avoid too many return statements within this function.
                                          Open

                                                          return None
                                          Severity: Major
                                          Found in plugins/System/Registry.py - About 30 mins to fix

                                            Avoid too many return statements within this function.
                                            Open

                                                            return str(value) == compareValue
                                            Severity: Major
                                            Found in plugins/System/Registry.py - About 30 mins to fix

                                              Avoid too many return statements within this function.
                                              Open

                                                              return None
                                              Severity: Major
                                              Found in plugins/System/Registry.py - About 30 mins to fix

                                                Avoid too many return statements within this function.
                                                Open

                                                                return False
                                                Severity: Major
                                                Found in plugins/System/Registry.py - About 30 mins to fix

                                                  Avoid too many return statements within this function.
                                                  Open

                                                              return 1
                                                  Severity: Major
                                                  Found in plugins/System/Registry.py - About 30 mins to fix

                                                    Avoid too many return statements within this function.
                                                    Open

                                                                    return value
                                                    Severity: Major
                                                    Found in plugins/System/Registry.py - About 30 mins to fix

                                                      Avoid too many return statements within this function.
                                                      Open

                                                                      return True
                                                      Severity: Major
                                                      Found in plugins/System/Registry.py - About 30 mins to fix

                                                        There are no issues that match your filters.

                                                        Category
                                                        Status