Sign upLogin

EventGhost/EventGhost

View on GitHub
Star
plugins/YamahaSerial/__init__.py

Summary

Maintainability
C
1 day
Test Coverage

File __init__.py has 392 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: latin-1 -*-
#
# YamahaSerial V0.0.1
# ================
# Written by Mark Clarkson, <mark@hollowhills.net>
Severity: Minor
Found in plugins/YamahaSerial/__init__.py - About 5 hrs to fix

    Function reader has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        def reader(self):
        line=""
        parmre=re.compile('(.)(.)(.)(..)(..)')
        while self.readerkiller is False:
            ch=self.serial.read()
    Severity: Minor
    Found in plugins/YamahaSerial/__init__.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def __init__(self):
        self.serial = None
        group = self
        self.currentVolume = -99
        self.TypList = {
    Severity: Minor
    Found in plugins/YamahaSerial/__init__.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                            if self.EventList[m.group(4)]['content']=='MasterVolume':
                            self.TriggerEvent(self.EventList[m.group(4)]['content'] + '.' + self.processVolume(m.group(5)))
                        else:
                            self.TriggerEvent(self.EventList[m.group(4)]['content'] + '.' + self.EventList[m.group(4)][m.group(5)])
                else:
    Severity: Major
    Found in plugins/YamahaSerial/__init__.py - About 45 mins to fix

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

          def Configure(self, port=0):
        panel = eg.ConfigPanel(self)
        portCtrl = panel.SerialPortChoice(port)
        panel.AddLine("Port:", portCtrl)
        while panel.Affirmed():
      Severity: Major
      Found in plugins/YamahaSerial/__init__.py and 8 other locations - About 40 mins to fix
      plugins/CambridgeAudioSerial/__init__.py on lines 294..299
      plugins/DenonSerial/__init__.py on lines 446..451
      plugins/H79Serial/__init__.py on lines 187..192
      plugins/JVCHD1Serial/__init__.py on lines 181..187
      plugins/JvcDlaSerial/__init__.py on lines 389..395
      plugins/Onkyo/__init__.py on lines 638..643
      plugins/SamsungTV/__init__.py on lines 259..264
      plugins/Tira/__init__.py on lines 133..138

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status