Sign upLogin

Excelian/Angular-Material-ECMA6-Dashboard

View on GitHub
Star

Showing 11 of 11 total issues

Function constructor has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor($scope, $interval, $filter) {

    this.displayControl = {
      filter: '',
      displayFrozen: false
Severity: Major
Found in client/app/components/dashboard/alerts/alerts.controller.js - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      it('Should create a toast on new user creation', function() {
    var userSettingsController = new UserSettingsController(UserService, mdToast);
    userSettingsController.addNewUser();
    $rootScope.$digest();
    expect(mdToast.show).toHaveBeenCalled();
    Severity: Major
    Found in client/app/components/dashboard/settings/user-settings.controller.spec.js and 1 other location - About 1 hr to fix
    client/app/components/dashboard/settings/user-settings.controller.spec.js on lines 51..56

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      it('Should call the new user service on add', function() {
    var userSettingsController = new UserSettingsController(UserService, mdToast);
    userSettingsController.addNewUser();
    $rootScope.$digest();
    expect(UserService.addNewUser).toHaveBeenCalled();
    Severity: Major
    Found in client/app/components/dashboard/settings/user-settings.controller.spec.js and 1 other location - About 1 hr to fix
    client/app/components/dashboard/settings/user-settings.controller.spec.js on lines 58..63

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function dashboardRoute has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function dashboardRoute($stateProvider) {
    $stateProvider.state(
      'app.services', {
        url: '/',
        template: serviceOverviewTemplate,
    Severity: Minor
    Found in client/app/routes/dashboard/dashboard.route.js - About 1 hr to fix

      Function logTick has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          var logTick = () => {

      $interval.cancel(logTickTimer);

      if (this.displayControl.displayFrozen) {
      Severity: Minor
      Found in client/app/components/dashboard/alerts/alerts.controller.js - About 1 hr to fix

        Function mainConfigModule has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          function ($locationProvider, $urlRouterProvider, $httpProvider, $compileProvider,
            $controllerProvider, $rootScopeProvider) {
        Severity: Minor
        Found in client/app/config/main.config.js - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            $mdThemingProvider.theme('default')
    .primaryPalette('blue', {
      'default': '900'
    })
    .accentPalette('blue-grey')
          Severity: Minor
          Found in client/app/config/main.config.js and 1 other location - About 35 mins to fix
          client/app/config/main.config.js on lines 44..51

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            $mdThemingProvider.theme('default-dark')
    .primaryPalette('blue', {
      'default': '900'
    })
    .accentPalette('blue-grey')
          Severity: Minor
          Found in client/app/config/main.config.js and 1 other location - About 35 mins to fix
          client/app/config/main.config.js on lines 35..42

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              userSettingsPage.users.then(function(items){
      expect(items.length).toEqual(2);
      done();
    });
          Severity: Minor
          Found in client/app/e2e/userSettings.e2e.js and 1 other location - About 35 mins to fix
          client/app/e2e/userSettings.e2e.js on lines 26..29

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              userSettingsPage.users.then(function(items){
      expect(items.length).toEqual(3);
      done();
    });
          Severity: Minor
          Found in client/app/e2e/userSettings.e2e.js and 1 other location - About 35 mins to fix
          client/app/e2e/userSettings.e2e.js on lines 16..19

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function constructor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            constructor($scope, $interval, $filter) {

    this.displayControl = {
      filter: '',
      displayFrozen: false
          Severity: Minor
          Found in client/app/components/dashboard/alerts/alerts.controller.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language