Sign upLogin

Eye4web/Eye4webZfcUserPm

View on GitHub
Star
src/Eye4web/ZfcUser/Pm/Controller/PmController.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method readConversationAction has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function readConversationAction()
    {
        if (!$this->zfcUserAuthentication()->hasIdentity()) {
            return $this->redirect()->toRoute($this->zfcUserOptions->getLoginRedirectRoute());
        }
Severity: Minor
Found in src/Eye4web/ZfcUser/Pm/Controller/PmController.php - About 1 hr to fix

    Method indexAction has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function indexAction()
    {
        if (!$this->zfcUserAuthentication()->hasIdentity()) {
            return $this->redirect()->toRoute($this->zfcUserOptions->getLoginRedirectRoute());
        }
    Severity: Minor
    Found in src/Eye4web/ZfcUser/Pm/Controller/PmController.php - About 1 hr to fix

      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              PmServiceInterface $pmService,
        NewConversationForm $newConversationForm,
        NewMessageForm $newMessageForm,
        DeleteConversationsForm $deleteConversationsForm,
        ModuleOptionsInterface $options,
      Severity: Minor
      Found in src/Eye4web/ZfcUser/Pm/Controller/PmController.php - About 45 mins to fix

        Avoid too many return statements within this method.
        Open

                return $this->redirect()->toRoute('eye4web/zfc-user/pm/read-conversation', ['conversationId' => $conversation->getId()]);
        Severity: Major
        Found in src/Eye4web/ZfcUser/Pm/Controller/PmController.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return $this->redirect()->toRoute('eye4web/zfc-user/pm/list');
          Severity: Major
          Found in src/Eye4web/ZfcUser/Pm/Controller/PmController.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return $this->redirect()->toRoute('eye4web/zfc-user/pm/list');
            Severity: Major
            Found in src/Eye4web/ZfcUser/Pm/Controller/PmController.php - About 30 mins to fix

              Function indexAction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function indexAction()
    {
        if (!$this->zfcUserAuthentication()->hasIdentity()) {
            return $this->redirect()->toRoute($this->zfcUserOptions->getLoginRedirectRoute());
        }
              Severity: Minor
              Found in src/Eye4web/ZfcUser/Pm/Controller/PmController.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status