FIRHQ/fir-cli

View on GitHub

Showing 9 of 9 total issues

Method publish has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def publish(*args, options)
      initialize_publish_options(args, options)
      logger_info_publishing_message

      logger.info 'begin to upload ...'
Severity: Minor
Found in lib/fir/util/publish.rb - About 1 hr to fix

    Method upload_app has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def upload_app
          time1 = Time.now.to_i
          app_uploaded_callback_data = if @options[:switch_to_qiniu]
                                         QiniuUploader.new(@app_info, @user_info, @uploading_info, @options).upload
                                       else
    Severity: Minor
    Found in lib/fir/util/publish.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method put_file has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def put_file(url, file, headers, need_progress = true)
    
          uri = URI(url)
          hostname = uri.hostname
    
    
    Severity: Minor
    Found in lib/fir/util/ali_uploader.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def initialize(req, &block)
        @req = req
        @callback = block
        @upload_size = 0
        if req.body_stream
    Severity: Minor
    Found in lib/fir/patches/progress.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method append_features has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def append_features(base)
          if base.instance_variable_defined?(:@_dependencies)
            base.instance_variable_get(:@_dependencies) << self
            return false
          else
    Severity: Minor
    Found in lib/fir/patches/concern.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize_output_path has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def initialize_output_path(options)
          if options[:output].blank?
            output_path = "#{@build_dir}/fir_build"
            FileUtils.mkdir_p(output_path) unless File.exist?(output_path)
            output_path
    Severity: Minor
    Found in lib/fir/util/build_common.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method invoke_command has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def invoke_command(command, *args)
            logfile = options[:logfile].blank? ? STDOUT : options[:logfile]
            logfile = '/dev/null' if options[:quiet]
    
            FIR.logger       = Logger.new(logfile)
    Severity: Minor
    Found in lib/fir/cli.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method try! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def try!(*a, &b)
        if a.empty? && block_given?
          if b.arity.zero?
            instance_eval(&b)
          else
    Severity: Minor
    Found in lib/fir/patches/try.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize_build_dir has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def initialize_build_dir(args, options)
          build_dir = args.first.to_s
          if File.extname(build_dir) == '.git'
            args.shift && git_clone_build_dir(build_dir, options)
          elsif build_dir.blank? || !File.exist?(build_dir)
    Severity: Minor
    Found in lib/fir/util/build_common.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language