FanaHOVA/blazer

View on GitHub
lib/blazer/data_source.rb

Summary

Maintainability
C
1 day
Test Coverage

Method run_statement has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    def run_statement(statement, options = {})
      run_id = options[:run_id]
      async = options[:async]
      result = nil
      if cache_mode != "off"
Severity: Minor
Found in lib/blazer/data_source.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class DataSource has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class DataSource
    extend Forwardable

    attr_reader :id, :settings, :adapter, :adapter_instance

Severity: Minor
Found in lib/blazer/data_source.rb - About 2 hrs to fix

    Method run_statement_helper has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        def run_statement_helper(statement, comment, run_id)
          start_time = Time.now
          columns, rows, error = @adapter_instance.run_statement(statement, comment)
          duration = Time.now - start_time
    
    
    Severity: Minor
    Found in lib/blazer/data_source.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run_statement has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def run_statement(statement, options = {})
          run_id = options[:run_id]
          async = options[:async]
          result = nil
          if cache_mode != "off"
    Severity: Minor
    Found in lib/blazer/data_source.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status