Sign upLogin

Fannon/mobo

View on GitHub
Star

Showing 152 of 152 total issues

Function readFiles has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.readFiles = function(files, type, callback) {

    'use strict';

    var content = {};
Severity: Minor
Found in lib/input/readProject.js - About 1 hr to fix

    Function analyzeForms has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.analyzeForms = function(forms) {
    'use strict';

    for (var formName in forms) {
    Severity: Minor
    Found in lib/modelToText/generateGraph.js - About 1 hr to fix

      Function applyImplicit has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      exports.applyImplicit = function(obj) {

    'use strict';

    var inspect = obj.items || obj;
      Severity: Minor
      Found in lib/modelToModel/compatibilityLayer.js - About 1 hr to fix

        Function objToTemplate has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.objToTemplate = function(name, obj) {

    if (!obj || Object.keys(obj).length === 0) {
        return '{{' + name + '}}\n'; // No unnecessary linebreaks
    }
        Severity: Minor
        Found in lib/modules/importHelper.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function inherit has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.inherit = function(obj, registry) {
    'use strict';

    if (obj.$path) {
        exports.inheritanceStack.push(obj.$path);
        Severity: Minor
        Found in lib/modelToModel/intermediaryLayer.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function exec has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports.exec = function(fileMap, importHelper, lib, registry, callback) {


    //////////////////////////////////////
    // Imports                          //
        Severity: Minor
        Found in examples/hardware/import/data/import.js - About 1 hr to fix

          Function registryStatistics has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          exports.registryStatistics = function(settings, registry) {
    'use strict';

    exports.settings = settings;
          Severity: Minor
          Found in lib/util/statistics.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                q.then(function(registry) {

        // 6) GENERATE WIKI STRUCTURE

        registry.statistics.benchmark.generateGraph = (new Date()).getTime() - exports.start;
            Severity: Major
            Found in lib/mobo.js and 1 other location - About 1 hr to fix
            lib/mobo.js on lines 137..143

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 68.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                q.then(function(registry) {

        // 5) OPTIONAL: BUILD GRAPH FROM MODEL

        registry.statistics.benchmark.validateExpandedRegistry = (new Date()).getTime() - exports.start;
            Severity: Major
            Found in lib/mobo.js and 1 other location - About 1 hr to fix
            lib/mobo.js on lines 146..152

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 68.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function analyzeFields has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

            exports.analyzeFields = function(fields) {
    'use strict';

    for (var fieldName in fields) {
            Severity: Minor
            Found in lib/modelToText/generateGraph.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function writeSchemas has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            exports.writeSchemas = function() {
    'use strict';

    // Requirements are function specific, because this function is very rarely called at all
    var fs = require('fs-extra');
            Severity: Minor
            Found in lib/util/documentation.js - About 1 hr to fix

              Function walk has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              exports.walk = function(dir, callback) {

    'use strict';

    var results = [];
              Severity: Minor
              Found in lib/input/readProject.js - About 1 hr to fix

                Function exec has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                exports.exec = function(settings, jobs) {

    'use strict';

    var i = 0;
                Severity: Minor
                Found in lib/modules/nuke.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function generateCategory has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                exports.generateCategory = function(settings, obj, name, registry) {

    // If smw_category is set to false, don't create a category
    if (obj.smw_category === false) {
        return false;
                Severity: Minor
                Found in lib/modelToText/transformModel.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function orderObjectProperties has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                exports.orderObjectProperties = function(obj) {
    'use strict';

    if (obj.properties) {
                Severity: Minor
                Found in lib/modelToModel/intermediaryLayer.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function interpretFile has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                exports.interpretFile = function(file, fileName, relativeFilePath, fileExtension) {

    var obj;
    var isObject = true;
                Severity: Minor
                Found in lib/input/readProject.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function prePostFix has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                exports.prePostFix = function(mode, model, registry) {

    var wikitext = '';

    if (model.items) {
                Severity: Minor
                Found in lib/util/moboUtil.js - About 1 hr to fix

                  Function mergeObjects has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  exports.mergeObjects = function(obj1, obj2) {
    return _.merge(obj1, obj2, function(objectValue, sourceValue, key) {

        if (_.isArray(objectValue)) {
                  Severity: Minor
                  Found in lib/modelToModel/intermediaryLayer.js - About 1 hr to fix

                    Function interpretFile has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    exports.interpretFile = function(file, fileName, relativeFilePath, fileExtension) {

    var obj;
    var isObject = true;
                    Severity: Minor
                    Found in lib/input/readProject.js - About 1 hr to fix

                      Function analyzeFields has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      exports.analyzeFields = function(fields) {
    'use strict';

    for (var fieldName in fields) {
                      Severity: Minor
                      Found in lib/modelToText/generateGraph.js - About 1 hr to fix
                        Severity
                        Category
                        Status
                        Source
                        Language