Fantom-foundation/go-lachesis

View on GitHub
gossip/ethapi_backend.go

Summary

Maintainability
D
1 day
Test Coverage

EthAPIBackend has 61 methods (exceeds 20 allowed). Consider refactoring.
Open

type EthAPIBackend struct {
    extRPCEnabled bool
    svc           *Service
    state         *EvmStateReader
    gpo           *gasprice.Oracle
Severity: Major
Found in gossip/ethapi_backend.go - About 1 day to fix

    File ethapi_backend.go has 570 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    package gossip
    
    import (
        "context"
        "errors"
    Severity: Minor
    Found in gossip/ethapi_backend.go - About 3 hrs to fix

      Method EthAPIBackend.GetFullEventID has 5 return statements (exceeds 4 allowed).
      Open

      func (b *EthAPIBackend) GetFullEventID(shortEventID string) (hash.Event, error) {
          s := strings.Split(shortEventID, ":")
          if len(s) == 1 {
              // it's a full hash
              return hash.HexToEventHash(shortEventID), nil
      Severity: Major
      Found in gossip/ethapi_backend.go - About 35 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func (b *EthAPIBackend) GetOriginationScore(ctx context.Context, stakerID idx.StakerID) (*big.Int, error) {
            if !b.svc.app.HasSfcStaker(stakerID) {
                return nil, nil
            }
            return b.svc.app.GetActiveOriginationScore(stakerID), nil
        Severity: Minor
        Found in gossip/ethapi_backend.go and 2 other locations - About 35 mins to fix
        gossip/ethapi_backend.go on lines 508..513
        gossip/ethapi_backend.go on lines 524..529

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 106.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func (b *EthAPIBackend) GetStakerPoI(ctx context.Context, stakerID idx.StakerID) (*big.Int, error) {
            if !b.svc.app.HasSfcStaker(stakerID) {
                return nil, nil
            }
            return b.svc.app.GetStakerPOI(stakerID), nil
        Severity: Minor
        Found in gossip/ethapi_backend.go and 2 other locations - About 35 mins to fix
        gossip/ethapi_backend.go on lines 508..513
        gossip/ethapi_backend.go on lines 516..521

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 106.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func (b *EthAPIBackend) GetValidationScore(ctx context.Context, stakerID idx.StakerID) (*big.Int, error) {
            if !b.svc.app.HasSfcStaker(stakerID) {
                return nil, nil
            }
            return b.svc.app.GetActiveValidationScore(stakerID), nil
        Severity: Minor
        Found in gossip/ethapi_backend.go and 2 other locations - About 35 mins to fix
        gossip/ethapi_backend.go on lines 516..521
        gossip/ethapi_backend.go on lines 524..529

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 106.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status