Sign upLogin

Fantom-foundation/go-lachesis

View on GitHub
Star
gossip/filters/api.go

Summary

Maintainability
D
1 day
Test Coverage

Method FilterCriteria.UnmarshalJSON has a Cognitive Complexity of 60 (exceeds 20 allowed). Consider refactoring.
Open

func (args *FilterCriteria) UnmarshalJSON(data []byte) error {
    type input struct {
        BlockHash *common.Hash     `json:"blockHash"`
        FromBlock *rpc.BlockNumber `json:"fromBlock"`
        ToBlock   *rpc.BlockNumber `json:"toBlock"`
Severity: Minor
Found in gossip/filters/api.go - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method FilterCriteria.UnmarshalJSON has 82 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (args *FilterCriteria) UnmarshalJSON(data []byte) error {
    type input struct {
        BlockHash *common.Hash     `json:"blockHash"`
        FromBlock *rpc.BlockNumber `json:"fromBlock"`
        ToBlock   *rpc.BlockNumber `json:"toBlock"`
Severity: Major
Found in gossip/filters/api.go - About 2 hrs to fix

    Method FilterCriteria.UnmarshalJSON has 9 return statements (exceeds 4 allowed).
    Open

    func (args *FilterCriteria) UnmarshalJSON(data []byte) error {
    type input struct {
        BlockHash *common.Hash     `json:"blockHash"`
        FromBlock *rpc.BlockNumber `json:"fromBlock"`
        ToBlock   *rpc.BlockNumber `json:"toBlock"`
    Severity: Major
    Found in gossip/filters/api.go - About 55 mins to fix

      Method PublicFilterAPI.Logs has 5 return statements (exceeds 4 allowed).
      Open

      func (api *PublicFilterAPI) Logs(ctx context.Context, crit FilterCriteria) (*rpc.Subscription, error) {
    notifier, supported := rpc.NotifierFromContext(ctx)
    if !supported {
        return &rpc.Subscription{}, rpc.ErrNotificationsUnsupported
    }
      Severity: Major
      Found in gossip/filters/api.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            go func() {
        for {
            select {
            case ph := <-pendingTxs:
                api.filtersMu.Lock()
        Severity: Major
        Found in gossip/filters/api.go and 1 other location - About 1 hr to fix
        gossip/filters/api.go on lines 298..314

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 156.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            go func() {
        for {
            select {
            case l := <-logs:
                api.filtersMu.Lock()
        Severity: Major
        Found in gossip/filters/api.go and 1 other location - About 1 hr to fix
        gossip/filters/api.go on lines 111..127

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 156.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func decodeTopic(s string) (common.Hash, error) {
    b, err := hexutil.Decode(s)
    if err == nil && len(b) != common.HashLength {
        err = fmt.Errorf("hex has invalid length %d after decoding; expected %d for topic", len(b), common.HashLength)
    }
        Severity: Minor
        Found in gossip/filters/api.go and 1 other location - About 35 mins to fix
        gossip/filters/api.go on lines 558..564

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func decodeAddress(s string) (common.Address, error) {
    b, err := hexutil.Decode(s)
    if err == nil && len(b) != common.AddressLength {
        err = fmt.Errorf("hex has invalid length %d after decoding; expected %d for address", len(b), common.AddressLength)
    }
        Severity: Minor
        Found in gossip/filters/api.go and 1 other location - About 35 mins to fix
        gossip/filters/api.go on lines 566..572

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status