Sign upLogin

Fantom-foundation/go-lachesis

View on GitHub
Star
gossip/peer.go

Summary

Maintainability
B
4 hrs
Test Coverage

peer has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

type peer struct {
    id string

    *p2p.Peer
    rw p2p.MsgReadWriter
Severity: Minor
Found in gossip/peer.go - About 2 hrs to fix

    Method peer.readStatus has 8 return statements (exceeds 4 allowed).
    Open

    func (p *peer) readStatus(network uint64, status *ethStatusData, genesis common.Hash) (err error) {
    msg, err := p.rw.ReadMsg()
    if err != nil {
        return err
    }
    Severity: Major
    Found in gossip/peer.go - About 50 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (p *peer) AsyncSendEvents(events inter.Events) {
    select {
    case p.queuedProps <- events:
        // Mark all the event hash as known, but ensure we don't overflow our limits
        for _, event := range events {
      Severity: Minor
      Found in gossip/peer.go and 1 other location - About 40 mins to fix
      gossip/peer.go on lines 200..213

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 108.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (p *peer) AsyncSendTransactions(txs []*types.Transaction) {
    select {
    case p.queuedTxs <- txs:
        // Mark all the transactions as known, but ensure we don't overflow our limits
        for _, tx := range txs {
      Severity: Minor
      Found in gossip/peer.go and 1 other location - About 40 mins to fix
      gossip/peer.go on lines 279..292

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 108.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status