Sign upLogin

Fantom-foundation/go-lachesis

View on GitHub
Star
gossip/serverpool.go

Summary

Maintainability
D
2 days
Test Coverage

Method serverPool.eventLoop has a Cognitive Complexity of 68 (exceeds 20 allowed). Consider refactoring.
Open

func (pool *serverPool) eventLoop() {
    lookupCnt := 0
    var convTime mclock.AbsTime
    if pool.discSetPeriod != nil {
        pool.discSetPeriod <- time.Millisecond * 100
Severity: Minor
Found in gossip/serverpool.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File serverpool.go has 678 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package gossip

import (
    "crypto/ecdsa"
    "fmt"
Severity: Minor
Found in gossip/serverpool.go - About 6 hrs to fix

    Method serverPool.eventLoop has 121 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (pool *serverPool) eventLoop() {
    lookupCnt := 0
    var convTime mclock.AbsTime
    if pool.discSetPeriod != nil {
        pool.discSetPeriod <- time.Millisecond * 100
    Severity: Major
    Found in gossip/serverpool.go - About 3 hrs to fix

      Avoid deeply nested control flow statements.
      Open

                          if pool.discSetPeriod != nil {
                        pool.discSetPeriod <- time.Minute
                    }
      Severity: Major
      Found in gossip/serverpool.go - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status