Fantom-foundation/go-lachesis

View on GitHub

Showing 829 of 829 total issues

Method ContractCreatedDelegationIterator.Next has 7 return statements (exceeds 4 allowed).
Open

func (it *ContractCreatedDelegationIterator) Next() bool {
    // If the iterator failed, stop iterating
    if it.fail != nil {
        return false
    }
Severity: Major
Found in gossip/sfc204/contract.go - About 45 mins to fix

    Method ContractUpdatedMinGasPriceIterator.Next has 7 return statements (exceeds 4 allowed).
    Open

    func (it *ContractUpdatedMinGasPriceIterator) Next() bool {
        // If the iterator failed, stop iterating
        if it.fail != nil {
            return false
        }
    Severity: Major
    Found in gossip/sfc204/contract.go - About 45 mins to fix

      Method ContractPreparedToWithdrawStakeIterator.Next has 7 return statements (exceeds 4 allowed).
      Open

      func (it *ContractPreparedToWithdrawStakeIterator) Next() bool {
          // If the iterator failed, stop iterating
          if it.fail != nil {
              return false
          }
      Severity: Major
      Found in gossip/sfc202/contract.go - About 45 mins to fix

        Method ContractUpdatedStakerMetadataIterator.Next has 7 return statements (exceeds 4 allowed).
        Open

        func (it *ContractUpdatedStakerMetadataIterator) Next() bool {
            // If the iterator failed, stop iterating
            if it.fail != nil {
                return false
            }
        Severity: Major
        Found in gossip/sfc202/contract.go - About 45 mins to fix

          Method ContractWithdrawnStakeIterator.Next has 7 return statements (exceeds 4 allowed).
          Open

          func (it *ContractWithdrawnStakeIterator) Next() bool {
              // If the iterator failed, stop iterating
              if it.fail != nil {
                  return false
              }
          Severity: Major
          Found in gossip/sfc202/contract.go - About 45 mins to fix

            Method ContractUpdatedStakerSfcAddressIterator.Next has 7 return statements (exceeds 4 allowed).
            Open

            func (it *ContractUpdatedStakerSfcAddressIterator) Next() bool {
                // If the iterator failed, stop iterating
                if it.fail != nil {
                    return false
                }
            Severity: Major
            Found in gossip/sfc110/contract.go - About 45 mins to fix

              Method ContractWithdrawnDelegationIterator.Next has 7 return statements (exceeds 4 allowed).
              Open

              func (it *ContractWithdrawnDelegationIterator) Next() bool {
                  // If the iterator failed, stop iterating
                  if it.fail != nil {
                      return false
                  }
              Severity: Major
              Found in gossip/sfc204/contract.go - About 45 mins to fix

                Method ContractUpgradedIterator.Next has 7 return statements (exceeds 4 allowed).
                Open

                func (it *ContractUpgradedIterator) Next() bool {
                    // If the iterator failed, stop iterating
                    if it.fail != nil {
                        return false
                    }
                Severity: Major
                Found in gossip/sfcproxy/contract.go - About 45 mins to fix

                  Method ContractIncreasedDelegationIterator.Next has 7 return statements (exceeds 4 allowed).
                  Open

                  func (it *ContractIncreasedDelegationIterator) Next() bool {
                      // If the iterator failed, stop iterating
                      if it.fail != nil {
                          return false
                      }
                  Severity: Major
                  Found in gossip/sfc202/contract.go - About 45 mins to fix

                    Method ContractUpdatedOfflinePenaltyThresholdIterator.Next has 7 return statements (exceeds 4 allowed).
                    Open

                    func (it *ContractUpdatedOfflinePenaltyThresholdIterator) Next() bool {
                        // If the iterator failed, stop iterating
                        if it.fail != nil {
                            return false
                        }
                    Severity: Major
                    Found in gossip/sfc202/contract.go - About 45 mins to fix

                      Method ContractUpdatedStakerSfcAddressIterator.Next has 7 return statements (exceeds 4 allowed).
                      Open

                      func (it *ContractUpdatedStakerSfcAddressIterator) Next() bool {
                          // If the iterator failed, stop iterating
                          if it.fail != nil {
                              return false
                          }
                      Severity: Major
                      Found in gossip/sfc202/contract.go - About 45 mins to fix

                        Similar blocks of code found in 5 locations. Consider refactoring.
                        Open

                        func (s *PublicSfcAPI) GetStakerDelegationsClaimedRewards(ctx context.Context, stakerID hexutil.Uint64) (*hexutil.Big, error) {
                            v, err := s.b.GetStakerDelegationsClaimedRewards(ctx, idx.StakerID(stakerID))
                            if err != nil {
                                return nil, err
                            }
                        Severity: Major
                        Found in ethapi/sfc_api.go and 4 other locations - About 45 mins to fix
                        ethapi/sfc_api.go on lines 25..31
                        ethapi/sfc_api.go on lines 34..40
                        ethapi/sfc_api.go on lines 58..64
                        ethapi/sfc_api.go on lines 88..94

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 115.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Method ContractPartialWithdrawnByRequestIterator.Next has 7 return statements (exceeds 4 allowed).
                        Open

                        func (it *ContractPartialWithdrawnByRequestIterator) Next() bool {
                            // If the iterator failed, stop iterating
                            if it.fail != nil {
                                return false
                            }
                        Severity: Major
                        Found in gossip/sfc110/contract.go - About 45 mins to fix

                          Method ContractUpdatedStakeIterator.Next has 7 return statements (exceeds 4 allowed).
                          Open

                          func (it *ContractUpdatedStakeIterator) Next() bool {
                              // If the iterator failed, stop iterating
                              if it.fail != nil {
                                  return false
                              }
                          Severity: Major
                          Found in gossip/sfc110/contract.go - About 45 mins to fix

                            Method ContractLockingStakeIterator.Next has 7 return statements (exceeds 4 allowed).
                            Open

                            func (it *ContractLockingStakeIterator) Next() bool {
                                // If the iterator failed, stop iterating
                                if it.fail != nil {
                                    return false
                                }
                            Severity: Major
                            Found in gossip/sfc204/contract.go - About 45 mins to fix

                              Method ContractCreatedStakeIterator.Next has 7 return statements (exceeds 4 allowed).
                              Open

                              func (it *ContractCreatedStakeIterator) Next() bool {
                                  // If the iterator failed, stop iterating
                                  if it.fail != nil {
                                      return false
                                  }
                              Severity: Major
                              Found in gossip/sfc202/contract.go - About 45 mins to fix

                                Method ContractCreatedWithdrawRequestIterator.Next has 7 return statements (exceeds 4 allowed).
                                Open

                                func (it *ContractCreatedWithdrawRequestIterator) Next() bool {
                                    // If the iterator failed, stop iterating
                                    if it.fail != nil {
                                        return false
                                    }
                                Severity: Major
                                Found in gossip/sfc202/contract.go - About 45 mins to fix

                                  Method ContractLockingDelegationIterator.Next has 7 return statements (exceeds 4 allowed).
                                  Open

                                  func (it *ContractLockingDelegationIterator) Next() bool {
                                      // If the iterator failed, stop iterating
                                      if it.fail != nil {
                                          return false
                                      }
                                  Severity: Major
                                  Found in gossip/sfc204/contract.go - About 45 mins to fix

                                    Similar blocks of code found in 5 locations. Consider refactoring.
                                    Open

                                    func (s *PublicSfcAPI) GetStakerClaimedRewards(ctx context.Context, stakerID hexutil.Uint64) (*hexutil.Big, error) {
                                        v, err := s.b.GetStakerClaimedRewards(ctx, idx.StakerID(stakerID))
                                        if err != nil {
                                            return nil, err
                                        }
                                    Severity: Major
                                    Found in ethapi/sfc_api.go and 4 other locations - About 45 mins to fix
                                    ethapi/sfc_api.go on lines 25..31
                                    ethapi/sfc_api.go on lines 34..40
                                    ethapi/sfc_api.go on lines 58..64
                                    ethapi/sfc_api.go on lines 97..103

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 115.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Method ContractIncreasedDelegationIterator.Next has 7 return statements (exceeds 4 allowed).
                                    Open

                                    func (it *ContractIncreasedDelegationIterator) Next() bool {
                                        // If the iterator failed, stop iterating
                                        if it.fail != nil {
                                            return false
                                        }
                                    Severity: Major
                                    Found in gossip/sfc110/contract.go - About 45 mins to fix
                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language