Fantom-foundation/go-lachesis

View on GitHub
poset/election/election_math.go

Summary

Maintainability
C
1 day
Test Coverage

Method Election.ProcessRoot has a Cognitive Complexity of 49 (exceeds 20 allowed). Consider refactoring.
Open

func (el *Election) ProcessRoot(newRoot RootAndSlot) (*Res, error) {
    res, err := el.chooseAtropos()
    if err != nil || res != nil {
        return res, err
    }
Severity: Minor
Found in poset/election/election_math.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Election.ProcessRoot has 81 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (el *Election) ProcessRoot(newRoot RootAndSlot) (*Res, error) {
    res, err := el.chooseAtropos()
    if err != nil || res != nil {
        return res, err
    }
Severity: Major
Found in poset/election/election_math.go - About 2 hrs to fix

    Method Election.ProcessRoot has 6 return statements (exceeds 4 allowed).
    Open

    func (el *Election) ProcessRoot(newRoot RootAndSlot) (*Res, error) {
        res, err := el.chooseAtropos()
        if err != nil || res != nil {
            return res, err
        }
    Severity: Major
    Found in poset/election/election_math.go - About 40 mins to fix

      There are no issues that match your filters.

      Category
      Status