Sign upLogin

FarmBot/Farmbot-Web-App

View on GitHub
Star
app/controllers/api/abstract_controller.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method stale_data? has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def stale_data?
      if resource
        updated_at = raw_json[:updated_at]
        if updated_at
          if resource.updated_at.as_json != updated_at
Severity: Minor
Found in app/controllers/api/abstract_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method mark_as_seen has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def mark_as_seen(bot = (current_user && current_user.device))
      when_farmbot_os do
        if bot
          v = fbos_version
          bot.last_saw_api = Time.now
Severity: Minor
Found in app/controllers/api/abstract_controller.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status