Sign upLogin

FarmBot/Farmbot-Web-App

View on GitHub
Star
app/controllers/api/tokens_controller.rb

Summary

Maintainability
A
35 mins
Test Coverage

Method create has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def create
      # Around June of 2020, we started getting Rails double
      # render errors on this endpoint when users would try
      # to log in with an unverified account (500 error).
      # Still not sure what changed or why, but this is a
Severity: Minor
Found in app/controllers/api/tokens_controller.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status