Sign upLogin

FarmBot/Farmbot-Web-App

View on GitHub
Star
app/models/device.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Device has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

class Device < ApplicationRecord
  DEFAULT_MAX_CONFIGS = 300
  DEFAULT_MAX_IMAGES = 100
  DEFAULT_MAX_LOGS = 1000
  DEFAULT_MAX_TELEMETRY = 300
Severity: Minor
Found in app/models/device.rb - About 3 hrs to fix

    File device.rb has 281 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Device < ApplicationRecord
  DEFAULT_MAX_CONFIGS = 300
  DEFAULT_MAX_IMAGES = 100
  DEFAULT_MAX_LOGS = 1000
  DEFAULT_MAX_TELEMETRY = 300
    Severity: Minor
    Found in app/models/device.rb - About 2 hrs to fix

      Method provide_feedback has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def provide_feedback(message, slug = "Not provided")
    webhook_url = ENV["FEEDBACK_WEBHOOK_URL"]
    if webhook_url
      email = self.users.pluck(:email).join(" ")
      name = self.users.first.name
      Severity: Major
      Found in app/models/device.rb - About 2 hrs to fix

        Method provide_feedback has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def provide_feedback(message, slug = "Not provided")
    webhook_url = ENV["FEEDBACK_WEBHOOK_URL"]
    if webhook_url
      email = self.users.pluck(:email).join(" ")
      name = self.users.first.name
        Severity: Minor
        Found in app/models/device.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status