Sign upLogin

FarmBot/Farmbot-Web-App

View on GitHub
Star
frontend/controls/controls.tsx

Summary

Maintainability
B
6 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      <div className={"tabs"}>
        <label className={move ? "selected" : ""}
          onClick={this.setPanelState("move")}>{t("move")}</label>
        <label className={peripherals ? "selected" : ""}
          onClick={this.setPanelState("peripherals")}>{t("peripherals")}</label>
Severity: Major
Found in frontend/controls/controls.tsx and 1 other location - About 6 hrs to fix
frontend/devices/connectivity/connectivity.tsx on lines 180..187

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 160.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  setPanelState = (key: keyof ControlsState) => () =>
    this.props.dispatch({
      type: Actions.SET_CONTROLS_PANEL_OPTION,
      payload: key,
    });
Severity: Major
Found in frontend/controls/controls.tsx and 9 other locations - About 35 mins to fix
frontend/curves/curves_inventory.tsx on lines 44..47
frontend/devices/connectivity/connectivity.tsx on lines 62..66
frontend/devices/jobs.tsx on lines 64..68
frontend/nav/index.tsx on lines 68..69
frontend/photos/photos.tsx on lines 38..39
frontend/plants/plant_inventory.tsx on lines 98..101
frontend/points/point_inventory.tsx on lines 154..157
frontend/sequences/panel/list.tsx on lines 45..49
frontend/weeds/weeds_inventory.tsx on lines 148..151

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status