Sign upLogin

FarmBot/Farmbot-Web-App

View on GitHub
Star
frontend/controls/peripherals/index.tsx

Summary

Maintainability
C
1 day
Test Coverage

Function render has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const { isEditing } = this.state;
    const status = getArrayStatus(this.props.peripherals);
    const editButtonText = isEditing
      ? t("Back")
Severity: Major
Found in frontend/controls/peripherals/index.tsx - About 2 hrs to fix

    Function stockPeripherals has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      get stockPeripherals() {
    const BASE_PERIPHERALS = [
      { pin: 7, label: t("Lighting") },
      { pin: 8, label: t("Water") },
      { pin: 9, label: t("Vacuum") },
    Severity: Minor
    Found in frontend/controls/peripherals/index.tsx - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            <EmptyStateWrapper
        notEmpty={this.props.peripherals.length > 0 || isEditing}
        graphic={EmptyStateGraphic.regimens}
        title={t("No Peripherals yet.")}
        text={Content.NO_PERIPHERALS}
      Severity: Major
      Found in frontend/controls/peripherals/index.tsx and 1 other location - About 2 hrs to fix
      frontend/sensors/index.tsx on lines 98..105

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 90.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              <button
          hidden={!isEditing}
          className="fb-button green"
          type="button"
          title={t("add peripheral")}
      Severity: Major
      Found in frontend/controls/peripherals/index.tsx and 1 other location - About 1 hr to fix
      frontend/sensors/index.tsx on lines 79..86

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              <button
          className="fb-button gray"
          onClick={this.toggle}
          title={editButtonText}
          disabled={!!status && isEditing}>
      Severity: Minor
      Found in frontend/controls/peripherals/index.tsx and 1 other location - About 55 mins to fix
      frontend/sensors/index.tsx on lines 68..74

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status