FarmBot/Farmbot-Web-App

File fbos_metric_history_plot.tsx has 261 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import React from "react";
import { trim } from "../../util";
import { Telemetry } from "farmbot/dist/resources/api_resources";
import { TaggedTelemetry } from "farmbot";
import { flatten, isNumber, last, max, range, sortBy } from "lodash";

Function getData has 37 lines of code (exceeds 25 allowed). Consider refactoring.

Open

const getData = (
  all: TaggedTelemetry[],
  metricName: keyof Telemetry,
): DataSegment[] => {
  const data: DataRecord[] = [];

Function VersionChangeLines has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

const VersionChangeLines = (props: VersionChangeLinesProps) => {
  const changes: VersionChangeRecord[] = [];
  const mostRecent = last(sortBy(props.telemetry, "body.created_at"));
  props.telemetry.map((d, i) => {
    if (i == 0) { return; }

Function FbosMetricHistoryPlot has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export const FbosMetricHistoryPlot = (props: FbosMetricHistoryPlotProps) => {
  const mostRecent = last(sortBy(props.telemetry, "body.created_at"));
  const hoveredSeconds = clipX(props.hoveredTime, mostRecent);
  return <svg
    className={"fbos-metric-history-plot-border"}

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        <text x={plotXSeconds(change.changedAt) - 3} y={VERSION_LABEL_Y_POSITION}
          fill={"gray"} textAnchor={"end"} style={{ textAnchor: "end" }}>
          v{change.previousVersion}
        </text>

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        <text x={plotXSeconds(change.changedAt) + 3} y={VERSION_LABEL_Y_POSITION}
          fill={"gray"} textAnchor={"start"} style={{ textAnchor: "start" }}>
          v{change.nextVersion}
        </text>

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    <line x1={0} y1={0} x2={MAX_X} y2={0} strokeWidth={0.25} stroke={"grey"} />

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    <line x1={0} y1={MAX_Y} x2={MAX_X} y2={MAX_Y}
      strokeWidth={0.25} stroke={"grey"} />

• Read up
  Read up