Sign upLogin

FarmBot/Farmbot-Web-App

View on GitHub
Star
frontend/farm_designer/location_info.tsx

Summary

Maintainability
D
2 days
Test Coverage

File location_info.tsx has 470 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from "react";
import { Everything, MovementState, TimeSettings } from "../interfaces";
import { BotPosition, UserEnv } from "../devices/interfaces";
import { connect } from "react-redux";
import { getUrlQuery } from "../util";
Severity: Minor
Found in frontend/farm_designer/location_info.tsx - About 7 hrs to fix

    Function ItemListWrapper has 74 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function ItemListWrapper(props: ItemListWrapperProps) {
  const { chosenXY } = props;
  const items = sortBy(groupItemsByLocation(props.items, chosenXY), "distance");
  const [expanded, setExpanded] = React.useState(false);
  if (items.length < 1) {
    Severity: Major
    Found in frontend/farm_designer/location_info.tsx - About 2 hrs to fix

      Function render has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        render() {
    const { chosenXY } = this;
    const allSoilHeightPoints = this.props.genericPoints.filter(soilHeightPoint);
    const getColorOverride = getSoilHeightColor(allSoilHeightPoints);
    const sensorReadings = this.props.sensorReadings
      Severity: Major
      Found in frontend/farm_designer/location_info.tsx - About 2 hrs to fix

        Function LocationActions has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const LocationActions = (props: LocationActionsProps) => {
  const navigate = useNavigate();
  return <div className={"location-actions"}>
    <MoveToForm
      chosenLocation={props.chosenLocation}
        Severity: Minor
        Found in frontend/farm_designer/location_info.tsx - About 1 hr to fix

          Function ImageListItem has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export const ImageListItem = (props: ImageListItemProps) => {
  const images = sortBy(props.images.items, "body.created_at").reverse();
  const [currentImage, setCurrentImage] = React.useState(images[0]);
  return <div className={"image-items"}>
    <ImageFlipper id={"image-items-flipper"}
          Severity: Minor
          Found in frontend/farm_designer/location_info.tsx - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                this.props.sensors.map(x => {
      sensorNameByPinLookup[x.body.pin || 0] = x.body.label;
    });
            Severity: Major
            Found in frontend/farm_designer/location_info.tsx and 1 other location - About 1 hr to fix
            frontend/sensors/sensor_readings/table.tsx on lines 86..88

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            interface LocationActionsProps {
  dispatch: Function;
  currentBotLocation: BotPosition;
  botOnline: boolean;
  locked: boolean;
            Severity: Minor
            Found in frontend/farm_designer/location_info.tsx and 1 other location - About 35 mins to fix
            frontend/farm_designer/move_to.tsx on lines 24..30

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status