Sign upLogin

FarmBot/Farmbot-Web-App

View on GitHub
Star
frontend/farm_designer/map/sequence_visualization.tsx

Summary

Maintainability
B
6 hrs
Test Coverage

Function preparePositions has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const preparePositions = (
  sequenceBody: SequenceBodyItem[],
  initialPosition: BotPosition,
  sequenceUuid: UUID | undefined,
) => {
Severity: Minor
Found in frontend/farm_designer/map/sequence_visualization.tsx - About 1 hr to fix

    Function reduceMoveAbsolute has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const reduceMoveAbsolute = (
  step: MoveAbsolute,
  sequenceUuid: UUID | undefined,
): Position | undefined => {
  const offset = step.args.offset.args;
    Severity: Minor
    Found in frontend/farm_designer/map/sequence_visualization.tsx - About 1 hr to fix

      Function reduceMoveAbsolute has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      const reduceMoveAbsolute = (
  step: MoveAbsolute,
  sequenceUuid: UUID | undefined,
): Position | undefined => {
  const offset = step.args.offset.args;
      Severity: Minor
      Found in frontend/farm_designer/map/sequence_visualization.tsx - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

            if (!(variable && variable.vector)) { return; }
      Severity: Major
      Found in frontend/farm_designer/map/sequence_visualization.tsx - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return {
        x: variable.vector.x + offset.x,
        y: variable.vector.y + offset.y,
      };
        Severity: Major
        Found in frontend/farm_designer/map/sequence_visualization.tsx - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                if (!sequenceUuid) { return; }
          Severity: Major
          Found in frontend/farm_designer/map/sequence_visualization.tsx - About 30 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                  return {
        x: variable.vector.x + offset.x,
        y: variable.vector.y + offset.y,
      };
            Severity: Minor
            Found in frontend/farm_designer/map/sequence_visualization.tsx and 2 other locations - About 35 mins to fix
            frontend/farm_designer/map/sequence_visualization.tsx on lines 278..281
            frontend/farm_designer/map/sequence_visualization.tsx on lines 286..289

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                  return {
        x: toolSlot.body.x + offset.x,
        y: toolSlot.body.y + offset.y,
      };
            Severity: Minor
            Found in frontend/farm_designer/map/sequence_visualization.tsx and 2 other locations - About 35 mins to fix
            frontend/farm_designer/map/sequence_visualization.tsx on lines 278..281
            frontend/farm_designer/map/sequence_visualization.tsx on lines 295..298

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                  return {
        x: point.body.x + offset.x,
        y: point.body.y + offset.y,
      };
            Severity: Minor
            Found in frontend/farm_designer/map/sequence_visualization.tsx and 2 other locations - About 35 mins to fix
            frontend/farm_designer/map/sequence_visualization.tsx on lines 286..289
            frontend/farm_designer/map/sequence_visualization.tsx on lines 295..298

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status