Sign upLogin

FarmBot/Farmbot-Web-App

View on GitHub
Star
frontend/farm_designer/panel_header.tsx

Summary

Maintainability
A
3 hrs
Test Coverage

Function getCurrentPanel has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

export const getCurrentPanel = (): Tabs | undefined => {
  if (Path.equals(Path.designer())) {
    return Panel.Map;
  } else if (Path.getSlug(Path.app()) == "sequences") {
    return Panel.Sequences;
Severity: Minor
Found in frontend/farm_designer/panel_header.tsx - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return compact(panelMatches)[0];
Severity: Major
Found in frontend/farm_designer/panel_header.tsx - About 30 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export enum PanelColor {
  green = "green",
  cyan = "cyan",
  brown = "brown",
  magenta = "magenta",
    Severity: Major
    Found in frontend/farm_designer/panel_header.tsx and 1 other location - About 1 hr to fix
    frontend/settings/firmware/firmware_hardware_support.ts on lines 149..161

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        <img width={35} height={30}
      src={TAB_ICON[props.panel]}
      title={PANEL_TITLE()[props.panel]} />
    Severity: Minor
    Found in frontend/farm_designer/panel_header.tsx and 1 other location - About 55 mins to fix
    frontend/nav/nav_links.tsx on lines 72..74

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status