FarmBot/Farmbot-Web-App

View on GitHub
frontend/farm_events/edit_fe_form.tsx

Summary

Maintainability
D
1 day
Test Coverage

File edit_fe_form.tsx has 507 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from "react";
import moment from "moment";
import { success, error, warning } from "../toast/toast";
import {
  TaggedFarmEvent, SpecialStatus, TaggedSequence, TaggedRegimen,
Severity: Major
Found in frontend/farm_events/edit_fe_form.tsx - About 1 day to fix

    Function render has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      render() {
        const { farmEvent } = this.props;
        const variableCount = Object.values(this.variableData || {})
          .filter(v => v?.celeryNode.kind == "parameter_declaration")
          .length;
    Severity: Minor
    Found in frontend/farm_events/edit_fe_form.tsx - About 1 hr to fix

      Function StartTimeForm has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const StartTimeForm = (props: StartTimeFormProps) => {
        const forceMidnight = props.isRegimen;
        const isNew = !parseInt("" + props.fieldGet("id"));
        const startDatetimeError = isNew && !forceMidnight &&
          !moment(props.now).isBefore(moment(offsetTime(props.fieldGet("startDate"),
      Severity: Minor
      Found in frontend/farm_events/edit_fe_form.tsx - About 1 hr to fix

        Function FarmEventForm has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export const FarmEventForm = (props: FarmEventFormProps) => {
          const { isRegimen, fieldGet, fieldSet, timeSettings } = props;
          return <div className="farm-event-form">
            <label>
              {t("Sequence or Regimen")}
        Severity: Minor
        Found in frontend/farm_events/edit_fe_form.tsx - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      <Collapse isOpen={!this.state.variablesCollapsed}>
                        <ErrorBoundary>
                          <this.LocalsList />
                        </ErrorBoundary>
                      </Collapse>
          Severity: Minor
          Found in frontend/farm_events/edit_fe_form.tsx and 1 other location - About 55 mins to fix
          frontend/regimens/editor/active_editor.tsx on lines 60..64

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          const startTimeWarning = () => {
            const message =
              t("Event start time needs to be in the future, not the past.");
            const title = t("Unable to save event.");
            error(message, { title });
          Severity: Minor
          Found in frontend/farm_events/edit_fe_form.tsx and 1 other location - About 40 mins to fix
          frontend/farm_events/edit_fe_form.tsx on lines 101..106

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          const nothingToRunWarning = () => {
            const message =
              t("All items scheduled before the start time. Nothing to run.");
            const title = t("Unable to save event.");
            error(message, { title });
          Severity: Minor
          Found in frontend/farm_events/edit_fe_form.tsx and 1 other location - About 40 mins to fix
          frontend/farm_events/edit_fe_form.tsx on lines 94..99

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status