FarmBot/Farmbot-Web-App

View on GitHub
frontend/folders/component.tsx

Summary

Maintainability
F
3 days
Test Coverage

File component.tsx has 467 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from "react";
import {
  BlurableInput,
  EmptyStateWrapper,
  EmptyStateGraphic,
Severity: Minor
Found in frontend/folders/component.tsx - About 7 hrs to fix

    Function FolderListItem has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const FolderListItem = (props: FolderItemProps) => {
      const { sequence, movedSequenceUuid, inUse } = props;
      const seqName = sequence.body.name;
      const url = Path.sequences(urlFriendly(seqName || ""));
      const moveSource = movedSequenceUuid === sequence.uuid ? "move-source" : "";
    Severity: Major
    Found in frontend/folders/component.tsx - About 2 hrs to fix

      Function FolderNameEditor has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const FolderNameEditor = (props: FolderNodeProps) => {
        const { node } = props;
        const [settingsOpen, setSettingsOpen] = React.useState(false);
        const [hovered, setHovered] = React.useState(false);
        return <div
      Severity: Minor
      Found in frontend/folders/component.tsx - About 1 hr to fix

        Function FolderNode has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const FolderNode = (props: FolderNodeProps) => {
          const { node, sequences } = props;
        
          const sequenceItems = node.content
            .filter(seqUuid => sequences[seqUuid])
        Severity: Minor
        Found in frontend/folders/component.tsx - About 1 hr to fix

          Function SequenceItemDescription has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          const SequenceItemDescription = (props: SequenceItemDescriptionProps) => {
            const { sequence, inUse } = props;
            const deprecatedSteps = JSON.stringify(props.sequence.body.body)
              .includes("resource_update");
            const { pinned, forked, sequence_version_id, description } = props.sequence.body;
          Severity: Minor
          Found in frontend/folders/component.tsx - About 1 hr to fix

            Function FolderListItem has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

            export const FolderListItem = (props: FolderItemProps) => {
              const { sequence, movedSequenceUuid, inUse } = props;
              const seqName = sequence.body.name;
              const url = Path.sequences(urlFriendly(seqName || ""));
              const moveSource = movedSequenceUuid === sequence.uuid ? "move-source" : "";
            Severity: Minor
            Found in frontend/folders/component.tsx - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function FolderNameEditor has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            export const FolderNameEditor = (props: FolderNodeProps) => {
              const { node } = props;
              const [settingsOpen, setSettingsOpen] = React.useState(false);
              const [hovered, setHovered] = React.useState(false);
              return <div
            Severity: Minor
            Found in frontend/folders/component.tsx - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    <div className={"stack-wrapper cluster-icon"}
                      title={t("Create subfolder")}
                      onClick={() => {
                        close();
                        createFolder({ parent_id: node.id, color: node.color });
            Severity: Major
            Found in frontend/folders/component.tsx and 1 other location - About 2 hrs to fix
            frontend/folders/component.tsx on lines 233..240

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 89.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  <div className={"stack-wrapper cluster-icon"}
                    title={t("add new sequence")}
                    onClick={() => {
                      close();
                      addNewSequenceToFolder({ id: node.id, color: node.color });
            Severity: Major
            Found in frontend/folders/component.tsx and 1 other location - About 2 hrs to fix
            frontend/folders/component.tsx on lines 225..232

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 89.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  <TestButton component={"list"}
                    syncStatus={props.syncStatus}
                    sequence={sequence}
                    resources={props.resources}
                    menuOpen={props.menuOpen}
            Severity: Major
            Found in frontend/folders/component.tsx and 1 other location - About 1 hr to fix
            frontend/controls/pinned_sequence_list.tsx on lines 25..30

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 65.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                <button
                  className="fb-button green"
                  title={t("add new sequence")}
                  onClick={() => { addNewSequenceToFolder(); }}>
                  <PlusStack icon={"fa-server"} />
            Severity: Major
            Found in frontend/folders/component.tsx and 1 other location - About 1 hr to fix
            frontend/folders/component.tsx on lines 483..488

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                <button
                  className="fb-button green"
                  title={t("create subfolder")}
                  onClick={() => { createFolder(); }}>
                  <PlusStack icon={"fa-folder"} />
            Severity: Major
            Found in frontend/folders/component.tsx and 1 other location - About 1 hr to fix
            frontend/folders/component.tsx on lines 489..494

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  <i
                    className={"fa fa-trash cluster-icon"}
                    title={t("delete sequence")}
                    onClick={deleteSequence({
                      sequenceUuid: sequence.uuid,
            Severity: Major
            Found in frontend/folders/component.tsx and 1 other location - About 1 hr to fix
            frontend/sequences/sequence_editor_middle_active.tsx on lines 322..328

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              toggleAll = () => {
                toggleAll(this.state.toggleDirection);
                this.setState({ toggleDirection: !this.state.toggleDirection });
              };
            Severity: Minor
            Found in frontend/folders/component.tsx and 1 other location - About 50 mins to fix
            frontend/sequences/panel/list.tsx on lines 51..54

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    target={<i className={`fa fa-ellipsis-v ${settingsOpen ? "open" : ""}`}
                      onClick={() => setSettingsOpen(!settingsOpen)} />}
            Severity: Minor
            Found in frontend/folders/component.tsx and 1 other location - About 50 mins to fix
            frontend/folders/component.tsx on lines 301..302

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  target={<i className={`fa fa-ellipsis-v ${settingsOpen ? "open" : ""}`}
                    onClick={() => setSettingsOpen(!settingsOpen)} />}
            Severity: Minor
            Found in frontend/folders/component.tsx and 1 other location - About 50 mins to fix
            frontend/folders/component.tsx on lines 113..114

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status