Sign upLogin

FarmBot/Farmbot-Web-App

View on GitHub
Star
frontend/photos/image_workspace/index.tsx

Summary

Maintainability
F
6 days
Test Coverage

Function render has 173 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const { H_LO, H_HI, S_LO, S_HI, V_LO, V_HI } = this.props;
    const cameraCalibrationEnv = this.props.namespace("H_LO").includes("CAMERA");
    const defaultHLow = this.getDefault(cameraCalibrationEnv ? "H_HI" : "H_LO");
    const defaultHHigh = this.getDefault(cameraCalibrationEnv ? "H_LO" : "H_HI");
Severity: Major
Found in frontend/photos/image_workspace/index.tsx - About 6 hrs to fix

    File index.tsx has 263 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React from "react";
import { FarmbotColorPicker } from "./farmbot_picker";
import { BlurableInput, Row, Help, ExpandableHeader } from "../../ui";
import { HSV } from "./interfaces";
import { WeedDetectorSlider } from "./slider";
    Severity: Minor
    Found in frontend/photos/image_workspace/index.tsx - About 2 hrs to fix

      Function render has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        render() {
    const { H_LO, H_HI, S_LO, S_HI, V_LO, V_HI } = this.props;
    const cameraCalibrationEnv = this.props.namespace("H_LO").includes("CAMERA");
    const defaultHLow = this.getDefault(cameraCalibrationEnv ? "H_HI" : "H_LO");
    const defaultHHigh = this.getDefault(cameraCalibrationEnv ? "H_LO" : "H_HI");
      Severity: Minor
      Found in frontend/photos/image_workspace/index.tsx - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                <Highlight settingName={this.props.sectionKey == "calibration"
            ? DeviceSetting.calibrationSaturation
            : DeviceSetting.detectionSaturation} pathPrefix={Path.photos}>
            <div className="row grid-exp-2 half-gap">
              <label htmlFor="saturation">{t("SATURATION")}</label>
      Severity: Major
      Found in frontend/photos/image_workspace/index.tsx and 1 other location - About 1 day to fix
      frontend/photos/image_workspace/index.tsx on lines 162..184

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 274.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                <Highlight settingName={this.props.sectionKey == "calibration"
            ? DeviceSetting.calibrationValue
            : DeviceSetting.detectionValue} pathPrefix={Path.photos}>
            <div className="row grid-exp-2 half-gap">
              <label htmlFor="value">{t("VALUE")}</label>
      Severity: Major
      Found in frontend/photos/image_workspace/index.tsx and 1 other location - About 1 day to fix
      frontend/photos/image_workspace/index.tsx on lines 139..161

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 274.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  <Highlight
              settingName={this.props.sectionKey == "calibration"
                ? DeviceSetting.calibrationIterations
                : DeviceSetting.detectionIterations}
              pathPrefix={Path.photos}>
      Severity: Major
      Found in frontend/photos/image_workspace/index.tsx and 1 other location - About 1 day to fix
      frontend/photos/image_workspace/index.tsx on lines 228..247

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 241.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  <Highlight
              settingName={this.props.sectionKey == "calibration"
                ? DeviceSetting.calibrationMorph
                : DeviceSetting.detectionMorph}
              pathPrefix={Path.photos}>
      Severity: Major
      Found in frontend/photos/image_workspace/index.tsx and 1 other location - About 1 day to fix
      frontend/photos/image_workspace/index.tsx on lines 248..267

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 241.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status