FarmBot/Farmbot-Web-App

View on GitHub
frontend/photos/images/photos.tsx

Summary

Maintainability
C
1 day
Test Coverage

Function render has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    return <div className="photos">
      <NewPhotoButtons
        syncStatus={this.props.syncStatus}
        botToMqttStatus={this.props.botToMqttStatus}
Severity: Minor
Found in frontend/photos/images/photos.tsx - About 1 hr to fix

    Function PhotoButtons has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const PhotoButtons = (props: PhotoButtonsProps) => {
      const { imageUrl } = props;
      const { image, dispatch, flags, size } = props;
      const imageShowMenuProps = { dispatch, flags, image, size };
      return <div className={"photo-action-buttons"}>
    Severity: Minor
    Found in frontend/photos/images/photos.tsx - About 1 hr to fix

      Function PhotoFooter has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const PhotoFooter = (props: PhotoFooterProps) => {
        const { image, timeSettings } = props;
        const created_at = image
          ? formatTime(moment(image.body.created_at), timeSettings, "MMMM Do, YYYY")
          : "";
      Severity: Minor
      Found in frontend/photos/images/photos.tsx - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          return <GoToThisLocationButton
            dispatch={props.dispatch}
            locationCoordinate={{ x, y, z }}
            botOnline={props.botOnline}
            arduinoBusy={props.arduinoBusy}
        Severity: Major
        Found in frontend/photos/images/photos.tsx and 2 other locations - About 3 hrs to fix
        frontend/plants/plant_panel.tsx on lines 202..209
        frontend/tools/tool_slot_edit_components.tsx on lines 136..143

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 96.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            {imageUrl &&
              <i title={t("Toggle crop")}
                className={[
                  "fa fa-scissors",
                  props.canCrop ? "" : "disabled",
        Severity: Major
        Found in frontend/photos/images/photos.tsx and 1 other location - About 1 hr to fix
        frontend/photos/images/photos.tsx on lines 85..92

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 74.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            {imageUrl &&
              <i title={t("Toggle rotation")}
                className={[
                  "fa fa-repeat",
                  props.canTransform ? "" : "disabled",
        Severity: Major
        Found in frontend/photos/images/photos.tsx and 1 other location - About 1 hr to fix
        frontend/photos/images/photos.tsx on lines 77..84

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 74.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status