Sign upLogin

FarmBot/Farmbot-Web-App

View on GitHub
Star
frontend/plants/crop_info.tsx

Summary

Maintainability
C
1 day
Test Coverage

File crop_info.tsx has 440 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from "react";
import { svgToUrl } from "../open_farm/icons";
import {
  CropInfoProps, CropLiveSearchResult, DesignerState, OpenfarmSearch,
} from "../farm_designer/interfaces";
Severity: Minor
Found in frontend/plants/crop_info.tsx - About 6 hrs to fix

    Function render has 102 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      render() {
    const { dispatch, designer } = this.props;
    const { cropSearchResults, cropSearchInProgress } = designer;
    const { crop, result, basePath, backgroundURL } =
      getCropHeaderProps({ cropSearchResults });
    Severity: Major
    Found in frontend/plants/crop_info.tsx - About 4 hrs to fix

      Function Companions has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const Companions = (props: CropInfoListProps) => {
  const { result, dispatch, openfarmCropFetch } = props;
  if (result.companions.length == 0) { return <div />; }
  return <InfoField title={"companions"}>
    <div className="crop-companions">
      Severity: Minor
      Found in frontend/plants/crop_info.tsx - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        const EMOJI: { [field: string]: string } = {
  binomial_name: "🏷",
  common_names: "🪪",
  sun_requirements: "🌞",
  sowing_method: "🌱",
        Severity: Minor
        Found in frontend/plants/crop_info.tsx and 1 other location - About 40 mins to fix
        frontend/settings/firmware/firmware_hardware_support.ts on lines 124..134

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status