Sign upLogin

FarmBot/Farmbot-Web-App

View on GitHub
Star
frontend/point_groups/criteria/apply.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function checkCriteria has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  (criteria: PointGroupCriteria, now: moment.Moment) =>
    (point: TaggedPoint, criteriaKey: keyof PointGroupCriteria) => {
      switch (criteriaKey) {
        case "string_eq":
        case "number_eq":
Severity: Minor
Found in frontend/point_groups/criteria/apply.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function checkCriteria has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    (point: TaggedPoint, criteriaKey: keyof PointGroupCriteria) => {
      switch (criteriaKey) {
        case "string_eq":
        case "number_eq":
          return every(Object.entries(criteria[criteriaKey])
Severity: Minor
Found in frontend/point_groups/criteria/apply.ts - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status