FarmBot/Farmbot-Web-App

View on GitHub
frontend/point_groups/criteria/component.tsx

Summary

Maintainability
D
1 day
Test Coverage

Function render has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const { group, dispatch, slugs } = this.props;
    const { criteria } = group.body;
    const commonProps = { group, criteria, dispatch };
    const dayProps = {
Severity: Minor
Found in frontend/point_groups/criteria/component.tsx - About 1 hr to fix

    Function render has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      render() {
        const { maxCount } = this.state;
        const { group, hovered, dispatch, iconDisplay } = this.props;
        const manuallyAddedIds = group.body.point_ids;
        const sortedPoints = this.sortedGroup;
    Severity: Minor
    Found in frontend/point_groups/criteria/component.tsx - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              {iconDisplay && criteriaPoints.length > 0 &&
                <div className={"point-list-wrapper"}>
                  {take(criteriaPoints, maxCount).map(generatePointIcons)}
                  <MoreIndicatorIcon count={criteriaPoints.length}
                    maxCount={maxCount} onClick={this.toggleExpand} />
      Severity: Major
      Found in frontend/point_groups/criteria/component.tsx and 1 other location - About 2 hrs to fix
      frontend/point_groups/criteria/component.tsx on lines 196..201

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 91.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            {iconDisplay && manualPoints.length > 0 &&
              <div className={"point-list-wrapper"}>
                {take(manualPoints, maxCount).map(generatePointIcons)}
                <MoreIndicatorIcon count={manualPoints.length}
                  maxCount={maxCount} onClick={this.toggleExpand} />
      Severity: Major
      Found in frontend/point_groups/criteria/component.tsx and 1 other location - About 2 hrs to fix
      frontend/point_groups/criteria/component.tsx on lines 207..212

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 91.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            <div className={"manual-group-member-count"}>
              <p>{`${manualPoints.length} ${t("manually selected")}`}</p>
              <ClearPointIds dispatch={dispatch} group={group} />
            </div>
      Severity: Major
      Found in frontend/point_groups/criteria/component.tsx and 1 other location - About 2 hrs to fix
      frontend/point_groups/criteria/component.tsx on lines 203..206

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 77.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              <div className={"criteria-group-member-count"}>
                <p>{`${criteriaPoints.length} ${t("selected by filters")}`}</p>
                <ClearCriteria dispatch={dispatch} group={group} />
              </div>
      Severity: Major
      Found in frontend/point_groups/criteria/component.tsx and 1 other location - About 2 hrs to fix
      frontend/point_groups/criteria/component.tsx on lines 192..195

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 77.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status