FarmBot/Farmbot-Web-App

View on GitHub
frontend/points/point_inventory.tsx

Summary

Maintainability
F
3 days
Test Coverage

Function render has 134 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const { dispatch } = this.props;
    const gridIds = compact(uniq(this.props.genericPoints
      .map(p => p.body.meta.gridId)));
    const points = orderedPoints(this.props.genericPoints, this.state)
Severity: Major
Found in frontend/points/point_inventory.tsx - About 5 hrs to fix

    File point_inventory.tsx has 287 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React from "react";
    import { connect } from "react-redux";
    import { PointInventoryItem } from "./point_inventory_item";
    import { Everything, PointsPanelState } from "../interfaces";
    import { DesignerNavTabs, Panel } from "../farm_designer/panel_header";
    Severity: Minor
    Found in frontend/points/point_inventory.tsx - About 2 hrs to fix

      Function PointsSection has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const PointsSection = (props: PointsSectionProps) => {
        const { genericPoints, isOpen, dispatch, averageZ, toggleAction } = props;
        return <div className={`points-section ${isOpen ? "open" : ""}`}>
          <div className={"points-section-header"} onClick={props.toggleOpen}>
            {props.color && <Saucer color={props.color} />}
      Severity: Minor
      Found in frontend/points/point_inventory.tsx - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              <DesignerPanelTop panel={Panel.Points}>
                <SearchField nameKey={"points"}
                  searchTerm={this.state.searchTerm}
                  placeholder={t("Search your points...")}
                  customLeftIcon={<PointSortMenu
        Severity: Major
        Found in frontend/points/point_inventory.tsx and 1 other location - About 4 hrs to fix
        frontend/weeds/weeds_inventory.tsx on lines 235..242

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 132.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          toggleGrid = (gridId: string) => () =>
            this.setState({
              gridIds: this.state.gridIds.includes(gridId)
                ? this.state.gridIds.filter(id => id != gridId)
                : this.state.gridIds.concat(gridId)
        Severity: Major
        Found in frontend/points/point_inventory.tsx and 1 other location - About 2 hrs to fix
        frontend/points/point_inventory.tsx on lines 147..152

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          toggleSoilHeightPointColor = (color: string) => () =>
            this.setState({
              soilHeightColors: this.state.soilHeightColors.includes(color)
                ? this.state.soilHeightColors.filter(c => c != color)
                : this.state.soilHeightColors.concat(color)
        Severity: Major
        Found in frontend/points/point_inventory.tsx and 1 other location - About 2 hrs to fix
        frontend/points/point_inventory.tsx on lines 140..145

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  <EmptyStateWrapper
                    notEmpty={this.props.genericPoints.length > 0}
                    graphic={EmptyStateGraphic.points}
                    title={t("No points yet.")}
                    text={Content.NO_POINTS}
        Severity: Major
        Found in frontend/points/point_inventory.tsx and 1 other location - About 1 hr to fix
        frontend/plants/plant_inventory.tsx on lines 215..232

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 72.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            const points = orderedPoints(this.props.genericPoints, this.state)
              .filter(p => p.body.name.toLowerCase()
                .includes(this.state.searchTerm.toLowerCase()));
        Severity: Major
        Found in frontend/points/point_inventory.tsx and 1 other location - About 1 hr to fix
        frontend/weeds/weeds_inventory.tsx on lines 144..145

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            const filteredGroups = pointGroups
              .filter(p => p.body.name.toLowerCase()
                .includes(this.state.searchTerm.toLowerCase()));
        Severity: Major
        Found in frontend/points/point_inventory.tsx and 5 other locations - About 1 hr to fix
        frontend/curves/curves_inventory.tsx on lines 84..86
        frontend/plants/plant_inventory.tsx on lines 107..109
        frontend/plants/plant_inventory.tsx on lines 111..113
        frontend/tools/index.tsx on lines 168..170
        frontend/weeds/weeds_inventory.tsx on lines 230..232

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

          toggleOpen = (section: keyof PointsPanelState) => () =>
            this.props.dispatch({
              type: Actions.TOGGLE_POINTS_PANEL_OPTION, payload: section,
            });
        Severity: Major
        Found in frontend/points/point_inventory.tsx and 9 other locations - About 35 mins to fix
        frontend/controls/controls.tsx on lines 62..66
        frontend/curves/curves_inventory.tsx on lines 44..47
        frontend/devices/connectivity/connectivity.tsx on lines 62..66
        frontend/devices/jobs.tsx on lines 64..68
        frontend/nav/index.tsx on lines 68..69
        frontend/photos/photos.tsx on lines 38..39
        frontend/plants/plant_inventory.tsx on lines 98..101
        frontend/sequences/panel/list.tsx on lines 45..49
        frontend/weeds/weeds_inventory.tsx on lines 148..151

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status