Sign upLogin

FarmBot/Farmbot-Web-App

View on GitHub
Star
frontend/resources/sequence_meta.ts

Summary

Maintainability
C
1 day
Test Coverage

Function determineDropdown has 95 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  (node: VariableNode, resources: ResourceIndex, uuid?: UUID): DropDownItem => {
    if (node.kind === "parameter_declaration") {
      return {
        label: t("Externally defined"),
        value: "?"
Severity: Major
Found in frontend/resources/sequence_meta.ts - About 3 hrs to fix

    Function determineDropdown has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      (node: VariableNode, resources: ResourceIndex, uuid?: UUID): DropDownItem => {
    if (node.kind === "parameter_declaration") {
      return {
        label: t("Externally defined"),
        value: "?"
    Severity: Minor
    Found in frontend/resources/sequence_meta.ts - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

            return formatTool(findToolById(resources, tool_id), toolSlot);
    Severity: Major
    Found in frontend/resources/sequence_meta.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return t("Add new");
      Severity: Major
      Found in frontend/resources/sequence_meta.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return {
          label: `${group.body.name} (${count})`,
          value
        };
        Severity: Major
        Found in frontend/resources/sequence_meta.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return undefined;
          Severity: Major
          Found in frontend/resources/sequence_meta.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return formatPoint(pointer);
            Severity: Major
            Found in frontend/resources/sequence_meta.ts - About 30 mins to fix

              Function determineVarDDILabel has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                (props: DetermineVarDDILabelProps): string => {
    const { label, resources, uuid, forceExternal } = props;
    if (forceExternal) { return t("Externally defined"); }
    const variable = maybeFindVariable(label, resources, uuid);
    if (variable) {
              Severity: Minor
              Found in frontend/resources/sequence_meta.ts - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    case "numeric":
        return {
          label: `${t("Number")}: ${data_value.args.number}`,
          value: data_value.args.number,
          headingId: "Numeric",
              Severity: Major
              Found in frontend/resources/sequence_meta.ts and 1 other location - About 1 hr to fix
              frontend/resources/sequence_meta.ts on lines 136..141

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 56.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    case "text":
        return {
          label: `${t("Text")}: ${data_value.args.string}`,
          value: data_value.args.string,
          headingId: "Text",
              Severity: Major
              Found in frontend/resources/sequence_meta.ts and 1 other location - About 1 hr to fix
              frontend/resources/sequence_meta.ts on lines 124..129

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 56.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    case "tool":
        const { tool_id } = data_value.args;
        const toolSlot = findSlotByToolId(resources, tool_id);
        return formatTool(findToolById(resources, tool_id), toolSlot);
              Severity: Minor
              Found in frontend/resources/sequence_meta.ts and 1 other location - About 35 mins to fix
              frontend/sequences/step_tiles/tile_computed_move/location.tsx on lines 115..118

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status