FarmBot/Farmbot-Web-App

View on GitHub
frontend/sequences/panel/list.tsx

Summary

Maintainability
B
6 hrs
Test Coverage

Function render has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const panelName = "designer-sequence-list";
    const panelState = this.props.sequencesPanelState;
    const buttonProps = Path.inDesigner()
      ? {
Severity: Major
Found in frontend/sequences/panel/list.tsx - About 2 hrs to fix

    Function SequenceListActions has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const SequenceListActions = (props: SequenceListActionsProps) => {
      const navigate = useNavigate();
      return <div className={"row"}>
        <button
          className={"fb-button green"}
    Severity: Minor
    Found in frontend/sequences/panel/list.tsx - About 1 hr to fix

      Function FeaturedSequenceListItem has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const FeaturedSequenceListItem = (props: FeaturedSequenceListItemProps) => {
        const { item } = props;
        const [importing, setImporting] = React.useState(false);
        const [descriptionOpen, setDescriptionOpen] = React.useState(false);
        return <li className={"sequence-list-item"}>
      Severity: Minor
      Found in frontend/sequences/panel/list.tsx - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          toggleAllFolders = () => {
            toggleAll(this.state.toggleDirection);
            this.setState({ toggleDirection: !this.state.toggleDirection });
          };
        Severity: Minor
        Found in frontend/sequences/panel/list.tsx and 1 other location - About 50 mins to fix
        frontend/folders/component.tsx on lines 412..415

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            axios.get(API.current.featuredSequencesPath)
              .then(response => this.setState({ featuredList: response.data }));
        Severity: Minor
        Found in frontend/sequences/panel/list.tsx and 1 other location - About 40 mins to fix
        frontend/featured/content.tsx on lines 46..47

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

          toggleSection = (key: keyof SequencesPanelState) => () =>
            this.props.dispatch({
              type: Actions.TOGGLE_SEQUENCES_PANEL_OPTION,
              payload: key,
            });
        Severity: Major
        Found in frontend/sequences/panel/list.tsx and 9 other locations - About 35 mins to fix
        frontend/controls/controls.tsx on lines 62..66
        frontend/curves/curves_inventory.tsx on lines 44..47
        frontend/devices/connectivity/connectivity.tsx on lines 63..67
        frontend/devices/jobs.tsx on lines 65..69
        frontend/nav/index.tsx on lines 69..70
        frontend/photos/photos.tsx on lines 65..66
        frontend/plants/plant_inventory.tsx on lines 98..101
        frontend/points/point_inventory.tsx on lines 154..157
        frontend/weeds/weeds_inventory.tsx on lines 150..153

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status