FarmBot/Farmbot-Web-App

View on GitHub
frontend/weeds/weeds_inventory.tsx

Summary

Maintainability
D
2 days
Test Coverage

File weeds_inventory.tsx has 264 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from "react";
import { connect } from "react-redux";
import { Everything, WeedsPanelState } from "../interfaces";
import { Panel } from "../farm_designer/panel_header";
import {
Severity: Minor
Found in frontend/weeds/weeds_inventory.tsx - About 2 hrs to fix

    Function WeedsSection has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const WeedsSection = (props: WeedsSectionProps) => {
      const { layerSetting } = props;
      const rawMaxSize = Math.max(...props.items.map(item => item.body.radius));
      const maxSize = isFinite(rawMaxSize) ? rawMaxSize : 0;
      const noWeeds = props.allWeeds?.length == 0;
    Severity: Major
    Found in frontend/weeds/weeds_inventory.tsx - About 2 hrs to fix

      Function render has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        render() {
          const weedGroups = pointGroupSubset(this.props.groups, "Weed");
          const filteredGroups = weedGroups
            .filter(p => p.body.name.toLowerCase()
              .includes(this.state.searchTerm.toLowerCase()));
      Severity: Minor
      Found in frontend/weeds/weeds_inventory.tsx - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              <DesignerPanelTop panel={Panel.Weeds}>
                <SearchField nameKey={"weeds"}
                  searchTerm={this.state.searchTerm}
                  placeholder={t("Search your weeds...")}
                  customLeftIcon={<PointSortMenu
        Severity: Major
        Found in frontend/weeds/weeds_inventory.tsx and 1 other location - About 4 hrs to fix
        frontend/points/point_inventory.tsx on lines 186..193

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 132.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                <PanelSection isOpen={this.props.weedsPanelState.groups}
                  panel={Panel.Weeds}
                  toggleOpen={this.toggleOpen("groups")}
                  itemCount={weedGroups.length}
                  addNew={() => this.props.dispatch(createGroup({
        Severity: Major
        Found in frontend/weeds/weeds_inventory.tsx and 1 other location - About 3 hrs to fix
        frontend/tools/index.tsx on lines 196..217

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            return orderedPoints(this.props.weeds, this.state).filter(p =>
              p.body.name.toLowerCase().includes(this.state.searchTerm.toLowerCase()));
        Severity: Major
        Found in frontend/weeds/weeds_inventory.tsx and 1 other location - About 1 hr to fix
        frontend/points/point_inventory.tsx on lines 169..171

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                {items.length > 0 &&
                  <button className={"fb-button red delete"}
                    title={t("delete all")}
                    onClick={deleteAllIds("weeds", items)}>
                    {t("delete all")}
        Severity: Major
        Found in frontend/weeds/weeds_inventory.tsx and 1 other location - About 1 hr to fix
        frontend/weeds/weeds_inventory.tsx on lines 181..186

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 64.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                {items.length > 0 &&
                  <button className={"fb-button red delete"}
                    title={t("delete all")}
                    onClick={deleteAllIds("weeds", items)}>
                    {t("delete all")}
        Severity: Major
        Found in frontend/weeds/weeds_inventory.tsx and 1 other location - About 1 hr to fix
        frontend/weeds/weeds_inventory.tsx on lines 214..219

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 64.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            const filteredGroups = weedGroups
              .filter(p => p.body.name.toLowerCase()
                .includes(this.state.searchTerm.toLowerCase()));
        Severity: Major
        Found in frontend/weeds/weeds_inventory.tsx and 5 other locations - About 1 hr to fix
        frontend/curves/curves_inventory.tsx on lines 90..92
        frontend/plants/plant_inventory.tsx on lines 111..113
        frontend/plants/plant_inventory.tsx on lines 115..117
        frontend/points/point_inventory.tsx on lines 179..181
        frontend/tools/index.tsx on lines 172..174

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  addNew={() => this.props.dispatch(createGroup({
                    criteria: {
                      ...DEFAULT_CRITERIA,
                      string_eq: { pointer_type: ["Weed"] },
                    },
        Severity: Minor
        Found in frontend/weeds/weeds_inventory.tsx and 1 other location - About 40 mins to fix
        frontend/tools/index.tsx on lines 199..204

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

          toggleOpen = (section: keyof WeedsPanelState) => () =>
            this.props.dispatch({
              type: Actions.TOGGLE_WEEDS_PANEL_OPTION, payload: section,
            });
        Severity: Major
        Found in frontend/weeds/weeds_inventory.tsx and 9 other locations - About 35 mins to fix
        frontend/controls/controls.tsx on lines 62..66
        frontend/curves/curves_inventory.tsx on lines 44..47
        frontend/devices/connectivity/connectivity.tsx on lines 63..67
        frontend/devices/jobs.tsx on lines 65..69
        frontend/nav/index.tsx on lines 69..70
        frontend/photos/photos.tsx on lines 65..66
        frontend/plants/plant_inventory.tsx on lines 98..101
        frontend/points/point_inventory.tsx on lines 154..157
        frontend/sequences/panel/list.tsx on lines 47..51

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status