FarmBot/Farmbot-Web-App

View on GitHub
frontend/wizard/step.tsx

Summary

Maintainability
C
1 day
Test Coverage

Function WizardStepContainer has 81 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const WizardStepContainer = (props: WizardStepContainerProps) => {
  const { step } = props;
  const setSuccess = props.setStepSuccess(step.slug);
  const requirementsMet =
    every(step.prerequisites?.map(prerequisite =>
Severity: Major
Found in frontend/wizard/step.tsx - About 3 hrs to fix

    Function TroubleshootingTips has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const TroubleshootingTips = (props: TroubleshootingTipsProps) => {
      const otherSelected = props.selectedOutcome == "other";
      return <div className={"troubleshooting"}>
        {props.step.outcomes.map(
          // eslint-disable-next-line complexity
    Severity: Major
    Found in frontend/wizard/step.tsx - About 2 hrs to fix

      Function WizardStepHeader has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const WizardStepHeader = (props: WizardStepHeaderProps) => {
        const stepOpen = props.stepOpen == props.step.slug;
        const resultDate = props.stepResult?.updated_at;
        const stepDone = props.stepResult?.answer;
        const stepFail = stepDone == false;
      Severity: Minor
      Found in frontend/wizard/step.tsx - About 1 hr to fix

        Function WizardStepHeader has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        export const WizardStepHeader = (props: WizardStepHeaderProps) => {
          const stepOpen = props.stepOpen == props.step.slug;
          const resultDate = props.stepResult?.updated_at;
          const stepDone = props.stepResult?.answer;
          const stepFail = stepDone == false;
        Severity: Minor
        Found in frontend/wizard/step.tsx - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                {step.pinBindingOptions &&
                  <PinBinding
                    getConfigValue={props.getConfigValue}
                    dispatch={props.dispatch}
                    pinBindingOptions={step.pinBindingOptions}
        Severity: Major
        Found in frontend/wizard/step.tsx and 1 other location - About 1 hr to fix
        frontend/farm_designer/map/legend/garden_map_legend.tsx on lines 260..266

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 63.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  <step.component setStepSuccess={setSuccess}
                    bot={props.bot}
                    dispatch={props.dispatch}
                    getConfigValue={props.getConfigValue}
                    resources={props.resources} />}
        Severity: Minor
        Found in frontend/wizard/step.tsx and 1 other location - About 50 mins to fix
        frontend/farm_designer/map/layers/zones/zones.tsx on lines 139..140

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                <button className={"fb-button gray"}
                  disabled={!requirementsMet}
                  onClick={setSuccess(false)}>
                  {t("no")}
                </button>
        Severity: Minor
        Found in frontend/wizard/step.tsx and 1 other location - About 35 mins to fix
        frontend/wizard/step.tsx on lines 115..119

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                <button className={"fb-button green"}
                  disabled={!requirementsMet}
                  onClick={setSuccess(true)}>
                  {t("yes")}
                </button>
        Severity: Minor
        Found in frontend/wizard/step.tsx and 1 other location - About 35 mins to fix
        frontend/wizard/step.tsx on lines 110..114

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                <a href={ExternalUrl.docsHub} target={"_blank"} rel={"noreferrer"}>
                  {t("hardware and software documentation hubs")}
                </a>
        Severity: Minor
        Found in frontend/wizard/step.tsx and 1 other location - About 30 mins to fix
        frontend/sequences/sequence_editor_middle_active.tsx on lines 138..140

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status