FarmBot/OpenFarm

View on GitHub
app/assets/stylesheets/styles/_presets.scss

Summary

Maintainability
Test Coverage

TODO found
Open

  // TODO(warpling): replace magic number

TODO found
Open

  // TODO(warpling): replace magic number

Use // comments everywhere
Open

/*

Use // comments everywhere
Open

/* When we have multiple stacked headers, we'll remove their bottom margin and let the parent handle it */

0px should be written without units as 0
Open

    @include box-shadow(0px 4px 0px 0px darken($of-red, 10%));

Color #DDD should be written as #ddd
Open

  color: #DDD;

Avoid vendor prefixes.
Open

  background-image: -ms-linear-gradient(to top, $from, $to);

Avoid using id selectors
Open

html,

Use // comments everywhere
Open

/* For "full-screen" rows that shouldn't be edge to edge on huge screens (~1440px) */

Properties should be ordered display, float, vertical-align
Open

  vertical-align: middle;

0px should be written without units as 0
Open

  @include box-shadow(0px 4px 0px 0px darken($of-green, 10%));

0px should be written without units as 0
Open

    @include box-shadow(0px 4px 0px 0px darken($of-red, 10%));

Color literals like rgba(0, 0, 0, 0.05) should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

    background-color: rgba(0, 0, 0, 0.05);

Prefer single quoted strings
Open

@import "compass/layout/sticky-footer";

Use // comments everywhere
Open

/*

Use // comments everywhere
Open

/* Apply to columns that should have the same bottom padding as left/right */

Each selector in a comma sequence should be on its own single line
Open

  &[disabled=disabled].loading, &[disabled].loading, &[disabled].loading:hover {

0px should be written without units as 0
Open

    @include box-shadow(0px 4px 0px 0px darken($of-red, 10%));

0px should be written without units as 0
Open

    @include box-shadow(0px 3px 0px 0px darken($secondary-color, 8%));

0px should be written without units as 0
Open

    @include box-shadow(0px 3px 0px 0px darken($secondary-color, 8%));

Avoid vendor prefixes.
Open

  background-image: -moz-linear-gradient(to top, $from, $to);

Properties should be ordered background, height, margin-bottom, padding-left, padding-right
Open

  height: $height;

Expected item on line 132 to appear before line 128. Rule sets should be ordered as follows: @extends, @includes without @content, properties, @includes with @content, nested rule sets
Open

  margin-bottom: 1.8rem;

0px should be written without units as 0
Open

  @include box-shadow(0px 4px 0px 0px darken($of-green, 10%));

0.025 should be written without a leading zero as .025
Open

    letter-spacing: 0.025rem;

URLs should be enclosed in quotes
Open

    background-image: url(ajax-loader-button-disabled.gif);

Color white should be written in hexadecimal form as #ffffff
Open

    color: white;

Use // comments everywhere
Open

/* Apply this to the column that should be vertically centered */

0px should be written without units as 0
Open

  @include box-shadow(0px 4px 0px 0px darken($of-green, 10%));

Expected item on line 224 to appear before line 222. Rule sets should be ordered as follows: @extends, @includes without @content, properties, @includes with @content, nested rule sets
Open

    @include box-shadow(0px 3px 0px 0px darken($secondary-color, 8%));

0.2 should be written without a leading zero as .2
Open

  transition: all 0.2s ease-in-out;

0px should be written without units as 0
Open

    @include box-shadow(0px 3px 0px 0px darken($secondary-color, 8%));

0.1 should be written without a leading zero as .1
Open

    background-color: rgba(0, 0, 0, 0.1);

0.15 should be written without a leading zero as .15
Open

  @include transition(all 0.15s ease-out);

Each selector in a comma sequence should be on its own single line
Open

.button, input[type=submit] {

Unnecessary parent selector (&)
Open

  & > a, & > a.title-wrapper {

Unnecessary parent selector (&)
Open

  & > a, & > a.title-wrapper {

Use // comments everywhere
Open

/*

Expected item on line 188 to appear before line 185. Rule sets should be ordered as follows: @extends, @includes without @content, properties, @includes with @content, nested rule sets
Open

  @include box-shadow(0px 4px 0px 0px darken($of-green, 10%));

Expected item on line 218 to appear before line 216. Rule sets should be ordered as follows: @extends, @includes without @content, properties, @includes with @content, nested rule sets
Open

    @include box-shadow(0px 4px 0px 0px darken($of-red, 10%));

Color #DDD should be written as #ddd
Open

  border: 2px dashed #DDD;

Properties should be ordered background-color, border-style
Open

    border-style: solid;

Color white should be written in hexadecimal form as #ffffff
Open

    color: white;

0.25 should be written without a leading zero as .25
Open

  background-color: rgba(0, 0, 0, 0.25);

Use // comments everywhere
Open

/*

Each selector in a comma sequence should be on its own single line
Open

  & > a, & > a.title-wrapper {

0.025 should be written without a leading zero as .025
Open

  letter-spacing: 0.025rem;

Use // comments everywhere
Open

  /* We shouldn't need vendor prefixed border-radius, but because of a bug in foundation-rails we do.

Avoid vendor prefixes.
Open

  background-image: -o-linear-gradient(to top, $from, $to);

Color literals like white should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

    color: white;

Color literals like #DDD should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

  color: #DDD;

Color literals like rgba(0, 0, 0, 0.1) should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

    background-color: rgba(0, 0, 0, 0.1);

Color literals like white should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

    color: white;

Avoid qualifying class selectors with an element.
Open

  & > a, & > a.title-wrapper {

Properties should be ordered bottom, left, position, right, top
Open

  position: absolute;

Properties should be ordered background-color, bottom, left, position, right, top
Open

  position: absolute;

Color literals like rgba(0, 0, 0, 0.25) should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

  background-color: rgba(0, 0, 0, 0.25);

0px should be written without units as 0
Open

  box-shadow: inset 0px 3px 0 darken($gray-bg, 10%);

Properties should be ordered color, font-size, line-height, margin, padding, text-align, vertical-align
Open

    margin: 0;

Avoid qualifying attribute selectors with an element.
Open

.button, input[type=submit] {

Properties should be ordered background, font-weight, transition
Open

  font-weight: 600;

Each selector in a comma sequence should be on its own single line
Open

  &[disabled=disabled].loading, &[disabled].loading, &[disabled].loading:hover {

0.05 should be written without a leading zero as .05
Open

    background-color: rgba(0, 0, 0, 0.05);

Use // comments everywhere
Open

/*

Use // comments everywhere
Open

/* Title bars that sit beneath the nav */

Use // comments everywhere
Open

/* Apply this to a row that will vertically center a column */

Color literals like #DDD should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

  border: 2px dashed #DDD;

There are no issues that match your filters.

Category
Status