FarmBot/OpenFarm

View on GitHub
spec/support/integration_helper.rb

Summary

Maintainability
A
0 mins
Test Coverage

Missing frozen string literal comment.
Open

module IntegrationHelper
Severity: Minor
Found in spec/support/integration_helper.rb by rubocop

This cop is designed to help you transition from mutable string literals to frozen string literals. It will add the comment # frozen_string_literal: true to the top of files to enable frozen string literals. Frozen string literals may be default in future Ruby. The comment will be added below a shebang and encoding comment.

Note that the cop will ignore files where the comment exists but is set to false instead of true.

Example: EnforcedStyle: always (default)

# The `always` style will always add the frozen string literal comment
# to a file, regardless of the Ruby version or if `freeze` or `<<` are
# called on a string literal.
# bad
module Bar
  # ...
end

# good
# frozen_string_literal: true

module Bar
  # ...
end

# good
# frozen_string_literal: false

module Bar
  # ...
end

Example: EnforcedStyle: never

# The `never` will enforce that the frozen string literal comment does
# not exist in a file.
# bad
# frozen_string_literal: true

module Baz
  # ...
end

# good
module Baz
  # ...
end

Example: EnforcedStyle: always_true

# The `always_true` style enforces that the frozen string literal
# comment is set to `true`. This is a stricter option than `always`
# and forces projects to use frozen string literals.
# bad
# frozen_string_literal: false

module Baz
  # ...
end

# bad
module Baz
  # ...
end

# good
# frozen_string_literal: true

module Bar
  # ...
end

Extra empty line detected at module body beginning.
Open


    def see(text)
Severity: Minor
Found in spec/support/integration_helper.rb by rubocop

This cop checks if empty lines around the bodies of modules match the configuration.

Example: EnforcedStyle: empty_lines

# good

module Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

module Foo
  module Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
module Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

module Foo
  def bar
    # ...
  end
end

Favor modifier until usage when having a single-line body.
Open

        until active == 0
Severity: Minor
Found in spec/support/integration_helper.rb by rubocop

Checks for while and until statements that would fit on one line if written as a modifier while/until. The maximum line length is configured in the Layout/LineLength cop.

Example:

# bad
while x < 10
  x += 1
end

# good
x += 1 while x < 10

Example:

# bad
until x > 10
  x += 1
end

# good
x += 1 until x > 10

Useless assignment to variable - element.
Open

      element = page.evaluate_script(script)
Severity: Minor
Found in spec/support/integration_helper.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Extra empty line detected at block body beginning.
Open


        active = page.evaluate_script('angular.element.active')
Severity: Minor
Found in spec/support/integration_helper.rb by rubocop

This cop checks if empty lines around the bodies of blocks match the configuration.

Example: EnforcedStyle: empty_lines

# good

foo do |bar|

  # ...

end

Example: EnforcedStyle: noemptylines (default)

# good

foo do |bar|
  # ...
end

There are no issues that match your filters.

Category
Status