Sign upLogin

FarmBot/OpenFarm

View on GitHub
Star
test/factories/requirement_option_range.rb

Summary

Maintainability
A
0 mins
Test Coverage

TODO found
Open

    # TODO: this could be much more sophisticated
Severity: Minor
Found in test/factories/requirement_option_range.rb by fixme

rand(1) always returns 0. Perhaps you meant rand(2) or rand?
Open

    options          { [rand(1..5), rand(5..20), rand(1)] }
Severity: Minor
Found in test/factories/requirement_option_range.rb by rubocop

This cop checks for rand(1) calls. Such calls always return 0.

Example:

# bad

rand 1
Kernel.rand(-1)
rand 1.0
rand(-1.0)

Example:

# good

0 # just use 0 instead

Missing frozen string literal comment.
Open

# Read about factories at https://github.com/thoughtbot/factory_bot
Severity: Minor
Found in test/factories/requirement_option_range.rb by rubocop

This cop is designed to help you transition from mutable string literals to frozen string literals. It will add the comment # frozen_string_literal: true to the top of files to enable frozen string literals. Frozen string literals may be default in future Ruby. The comment will be added below a shebang and encoding comment.

Note that the cop will ignore files where the comment exists but is set to false instead of true.

Example: EnforcedStyle: always (default)

# The `always` style will always add the frozen string literal comment
# to a file, regardless of the Ruby version or if `freeze` or `<<` are
# called on a string literal.
# bad
module Bar
  # ...
end

# good
# frozen_string_literal: true

module Bar
  # ...
end

# good
# frozen_string_literal: false

module Bar
  # ...
end

Example: EnforcedStyle: never

# The `never` will enforce that the frozen string literal comment does
# not exist in a file.
# bad
# frozen_string_literal: true

module Baz
  # ...
end

# good
module Baz
  # ...
end

Example: EnforcedStyle: always_true

# The `always_true` style enforces that the frozen string literal
# comment is set to `true`. This is a stricter option than `always`
# and forces projects to use frozen string literals.
# bad
# frozen_string_literal: false

module Baz
  # ...
end

# bad
module Baz
  # ...
end

# good
# frozen_string_literal: true

module Bar
  # ...
end

There are no issues that match your filters.

Category
Status