Sign upLogin

FelixMcFelix/webrtc-conductor

View on GitHub
Star

Showing 13 of 13 total issues

Function WebRTCResourceManager has a Cognitive Complexity of 92 (exceeds 5 allowed). Consider refactoring.
Open

function WebRTCResourceManager(config){
    this._channelRegistry = {};
    this._connectionRegistry = {};

    let _lookupChannel = id => {
Severity: Minor
Found in src/wrtc-res-man.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function WebRTCResourceManager has 254 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function WebRTCResourceManager(config){
    this._channelRegistry = {};
    this._connectionRegistry = {};

    let _lookupChannel = id => {
Severity: Major
Found in src/wrtc-res-man.js - About 1 day to fix

    File wrtc-res-man.js has 337 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    "use strict";

const wrtc_adapter = require("webrtc-adapter-test")
    , enums = {
        RESPONSE_NONE: Symbol("Miscellaneous Response"),
    Severity: Minor
    Found in src/wrtc-res-man.js - About 4 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  case(enums.RESPONSE_ICE):
                console.log("ICE candidate picked up by manager.");
                target.connection.addIceCandidate(new this.config.rtc_facade.RTCIceCandidate(data))
                    .then(
                          result => console.log("Successfully added ICE candidate to connection "+input.id),
      Severity: Major
      Found in src/wrtc-res-man.js and 1 other location - About 3 hrs to fix
      src/wrtc-res-man.js on lines 292..299

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 108.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  case(enums.RESPONSE_SDP_ANSWER):
                console.log("SDP answer picked up by manager.");
                target.connection.setRemoteDescription(new this.config.rtc_facade.RTCSessionDescription(data))
                .then(
                          result => console.log("Successfully added SDP Answer to connection "+input.id),
      Severity: Major
      Found in src/wrtc-res-man.js and 1 other location - About 3 hrs to fix
      src/wrtc-res-man.js on lines 270..277

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 108.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function connectTo has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          this.connectTo = (id, channel) => {
        // Return an instance of a given connection by its id.
        // This increments a connection's usage counter.
        // If the channel supplied is an id, look it up in the registry.
        //        If it has been bound to this, use it. If bound to another manager, throw.
      Severity: Major
      Found in src/wrtc-res-man.js - About 2 hrs to fix

        Function TrackedConnection has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function TrackedConnection(id, rtcConn){
    // let _usages = 0;

    // Object.defineProperty(this, {
    //     "usages": {
        Severity: Major
        Found in src/wrtc-res-man.js - About 2 hrs to fix

          Function response has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              this.response = (msg, channel) => {
        // Call this function to to pass a response from a channel to the correct channel handler.
        // channel may either be a channel object or an id - in both cases the channel object MUST
        // be registered to the controller.
        channel = _channelFromObjectOrId(channel);
          Severity: Minor
          Found in src/wrtc-res-man.js - About 1 hr to fix

            Function TrackedConnection has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

            function TrackedConnection(id, rtcConn){
    // let _usages = 0;

    // Object.defineProperty(this, {
    //     "usages": {
            Severity: Minor
            Found in src/wrtc-res-man.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _newConnection has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                _newConnection = (id, channel, response) => {
        let conn = new this.config.rtc_facade.RTCPeerConnection(this.config.rtc_config),
            trConn = new TrackedConnection(id, conn),
            t = this;
            Severity: Minor
            Found in src/wrtc-res-man.js - About 1 hr to fix

              Parsing error: The keyword 'const' is reserved
              Open

              const wrtc_adapter = require("webrtc-adapter-test")
              Severity: Minor
              Found in src/wrtc-res-man.js by eslint

              For more information visit Source: http://eslint.org/docs/rules/

              Parsing error: The keyword 'const' is reserved
              Open

              const gulp = require("gulp")
              Severity: Minor
              Found in gulpfile.js by eslint

              For more information visit Source: http://eslint.org/docs/rules/

              TODO found
              Open

                      // TODO - closes for real right now.
              Severity: Minor
              Found in src/wrtc-res-man.js by fixme
              Severity
              Category
              Status
              Source
              Language